From kwin Sat Aug 27 18:21:32 2011 From: "Melchior Franz" Date: Sat, 27 Aug 2011 18:21:32 +0000 To: kwin Subject: Re: Review Request: tabstrip win deco: make outline color configurable Message-Id: <20110827182132.9693.67314 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=131446931408045 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2475179988698766473==" --===============2475179988698766473== Content-Type: multipart/alternative; boundary="===============0850077329284809591==" --===============0850077329284809591== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 27, 2011, 4:13 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > I don't mind much about Tabstrip. As I don't expect the original author= to comment on it :-( and what I see looks fine, I give you a shipit. > > = > > Thanks for the patch and it's always nice seeing someone improve the ha= rdly maintained decorations :-) Thanks, committed. https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revi= sions/09c152aca0735cb7791bb7369714c184699ac955 - Melchior ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102438/#review6065 ----------------------------------------------------------- On Aug. 26, 2011, 1:44 p.m., Melchior Franz wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102438/ > ----------------------------------------------------------- > = > (Updated Aug. 26, 2011, 1:44 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > In addition to the black background frame and the colored titlebar the "t= abstrip" window decoration also has an outline, which is currently hard-cod= ed as white. This doesn't fit very well in certain color combinations, espe= cially in dark setups, so it is desirable to make this color configurable. = The idea has been ACK'ed by the tabstrip authors (Jorge MATA: "I think it w= ould be a good idea to have a color chooser in the decoration configuration= for this setting." and Lucas MURRAY: "Lovely"). > = > The config dialog (attached screenshot) isn't particularly pleasing, but = I found it hard to align the three different widgets in a meaningful way. T= he first screenshot shows the deco with grouped windows and black as outlin= e color. You can see that the title bar composition doesn't become unclear = if the outline is invisible, even in grouped mode. The second screenshot sh= ows windows with different combinations copied together as an illustration.= The top row corresponds to the currently hardcoded outline color white. > = > = > Diffs > ----- > = > kwin/clients/tabstrip/config/tabstripconfig.cpp 4174cba = > kwin/clients/tabstrip/config/tabstripconfig.ui 1a21e05 = > kwin/clients/tabstrip/tabstripdecoration.cpp ae46872 = > kwin/clients/tabstrip/tabstripfactory.h 2b667f0 = > kwin/clients/tabstrip/tabstripfactory.cpp 591a148 = > = > Diff: http://git.reviewboard.kde.org/r/102438/diff > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > black outline > http://git.reviewboard.kde.org/r/102438/s/241/ > white (default), green, olive outline > http://git.reviewboard.kde.org/r/102438/s/242/ > config > http://git.reviewboard.kde.org/r/102438/s/243/ > = > = > Thanks, > = > Melchior > = > --===============0850077329284809591== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102438/

On August 27th, 2011, 4:13 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:

I don'=
;t mind much about Tabstrip. As I don't expect the original author to c=
omment on it :-( and what I see looks fine, I give you a shipit.

Thanks for the patch and it's always nice seeing someone improve the ha=
rdly maintained decorations :-)
Thanks, com=
mitted.

https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revi=
sions/09c152aca0735cb7791bb7369714c184699ac955

- Melchior


On August 26th, 2011, 1:44 p.m., Melchior Franz wrote:

Review request for kwin.
By Melchior Franz.

Updated Aug. 26, 2011, 1:44 p.m.

Descripti= on 

In addition to the black background frame and the colored ti=
tlebar the "tabstrip" window decoration also has an outline, whic=
h is currently hard-coded as white. This doesn't fit very well in certa=
in color combinations, especially in dark setups, so it is desirable to mak=
e this color configurable. The idea has been ACK'ed by the tabstrip aut=
hors (Jorge MATA: "I think it would be a good idea to have a color cho=
oser in the decoration configuration for this setting." and Lucas MURR=
AY: "Lovely").

The config dialog (attached screenshot) isn't particularly pleasing, bu=
t I found it hard to align the three different widgets in a meaningful way.=
 The first screenshot shows the deco with grouped windows and black as outl=
ine color. You can see that the title bar composition doesn't become un=
clear if the outline is invisible, even in grouped mode. The second screens=
hot shows windows with different combinations copied together as an illustr=
ation. The top row corresponds to the currently hardcoded outline color whi=
te.

Diffs=

  • kwin/clients/tabstrip/config/tabstripconfig.cpp (4174cba)
  • kwin/clients/tabstrip/config/tabstripconfig.ui (1a21e05)
  • kwin/clients/tabstrip/tabstripdecoration.cpp (ae46872)
  • kwin/clients/tabstrip/tabstripfactory.h (2= b667f0)
  • kwin/clients/tabstrip/tabstripfactory.cpp = (591a148)

View Diff

Screensho= ts

3D"black 3D"white 3D"config"
--===============0850077329284809591==-- --===============2475179988698766473== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2475179988698766473==--