This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102438/

On August 27th, 2011, 4:13 p.m., Martin Gräßlin wrote:

I don't mind much about Tabstrip. As I don't expect the original author to comment on it :-( and what I see looks fine, I give you a shipit.

Thanks for the patch and it's always nice seeing someone improve the hardly maintained decorations :-)
Thanks, committed.

https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/09c152aca0735cb7791bb7369714c184699ac955

- Melchior


On August 26th, 2011, 1:44 p.m., Melchior Franz wrote:

Review request for kwin.
By Melchior Franz.

Updated Aug. 26, 2011, 1:44 p.m.

Description

In addition to the black background frame and the colored titlebar the "tabstrip" window decoration also has an outline, which is currently hard-coded as white. This doesn't fit very well in certain color combinations, especially in dark setups, so it is desirable to make this color configurable. The idea has been ACK'ed by the tabstrip authors (Jorge MATA: "I think it would be a good idea to have a color chooser in the decoration configuration for this setting." and Lucas MURRAY: "Lovely").

The config dialog (attached screenshot) isn't particularly pleasing, but I found it hard to align the three different widgets in a meaningful way. The first screenshot shows the deco with grouped windows and black as outline color. You can see that the title bar composition doesn't become unclear if the outline is invisible, even in grouped mode. The second screenshot shows windows with different combinations copied together as an illustration. The top row corresponds to the currently hardcoded outline color white.

Diffs

  • kwin/clients/tabstrip/config/tabstripconfig.cpp (4174cba)
  • kwin/clients/tabstrip/config/tabstripconfig.ui (1a21e05)
  • kwin/clients/tabstrip/tabstripdecoration.cpp (ae46872)
  • kwin/clients/tabstrip/tabstripfactory.h (2b667f0)
  • kwin/clients/tabstrip/tabstripfactory.cpp (591a148)

View Diff

Screenshots

black outline white (default), green, olive outline config