'Review Request: Query used compositing backend through DBus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Query used compositing backend through DBus
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-08-20 14:37:42
Message-ID: 20110820143742.26034.74020 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102387/
-----------------------------------------------------------

Review request for kwin and Arthur Arlt.

Summary
-------

It annoys me from time to time that I do not know whether kwin uses OpenGL =
or falls back to XRender (e.g. on tablet). So this ends the problem by just=
 asking on DBus.

I will wait with committing till Arthur finished the last bit of splitting =
out the Workspace methods in composite into a Compositor class and will the=
n export a new Object /Compositor on the DBus interface.

Diffs
-----

  kwin/composite.cpp 2b8ea6f =

  kwin/org.kde.KWin.xml bd993ed =

  kwin/scene.h 6ce39c0 =

  kwin/scene_opengl.h 600ae2e =

  kwin/scene_opengl_egl.cpp 4e232c2 =

  kwin/scene_opengl_glx.cpp 06a7b0a =

  kwin/scene_xrender.h 6c916c8 =

  kwin/scene_xrender.cpp 73dd22f =

  kwin/workspace.h 2cba848 =

Diff: http://git.reviewboard.kde.org/r/102387/diff

Testing
-------

* kwin_gles returns OpenGL ES 2.0
* kwin returns OpenGL 2.x
* No Compositing returns No Compositing
* XRender I assume returns XRender.

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102387/">http://git.reviewboard.kde.org/r/102387/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Arthur Arlt.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It annoys me from time to time that I do not know whether kwin uses \
OpenGL or falls back to XRender (e.g. on tablet). So this ends the problem by just \
asking on DBus.

I will wait with committing till Arthur finished the last bit of splitting out the \
Workspace methods in composite into a Compositor class and will then export a new \
Object /Compositor on the DBus interface.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* kwin_gles returns OpenGL ES 2.0
* kwin returns OpenGL 2.x
* No Compositing returns No Compositing
* XRender I assume returns XRender.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(2b8ea6f)</span></li>

 <li>kwin/org.kde.KWin.xml <span style="color: grey">(bd993ed)</span></li>

 <li>kwin/scene.h <span style="color: grey">(6ce39c0)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(600ae2e)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: grey">(4e232c2)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: grey">(06a7b0a)</span></li>

 <li>kwin/scene_xrender.h <span style="color: grey">(6c916c8)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(73dd22f)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(2cba848)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102387/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 