'Re: Review Request: Query used compositing backend through DBus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Query used compositing backend through DBus
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-11-13 18:39:19
Message-ID: 20111113183919.14371.56896 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102387/#review8183
-----------------------------------------------------------

Any "progress" on this (ie. "is arthur done?")
KWin could use some more dbus hooks for status inspection.

- Thomas L=C3=BCbking

On Aug. 20, 2011, 2:37 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102387/
> -----------------------------------------------------------
> =

> (Updated Aug. 20, 2011, 2:37 p.m.)
> =

> =

> Review request for kwin and Arthur Arlt.
> =

> =

> Description
> -------
> =

> It annoys me from time to time that I do not know whether kwin uses OpenG=
L or falls back to XRender (e.g. on tablet). So this ends the problem by ju=
st asking on DBus.
> =

> I will wait with committing till Arthur finished the last bit of splittin=
g out the Workspace methods in composite into a Compositor class and will t=
hen export a new Object /Compositor on the DBus interface.
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp 2b8ea6f =

>   kwin/org.kde.KWin.xml bd993ed =

>   kwin/scene.h 6ce39c0 =

>   kwin/scene_opengl.h 600ae2e =

>   kwin/scene_opengl_egl.cpp 4e232c2 =

>   kwin/scene_opengl_glx.cpp 06a7b0a =

>   kwin/scene_xrender.h 6c916c8 =

>   kwin/scene_xrender.cpp 73dd22f =

>   kwin/workspace.h 2cba848 =

> =

> Diff: http://git.reviewboard.kde.org/r/102387/diff/diff
> =

> =

> Testing
> -------
> =

> * kwin_gles returns OpenGL ES 2.0
> * kwin returns OpenGL 2.x
> * No Compositing returns No Compositing
> * XRender I assume returns XRender.
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102387/">http://git.reviewboard.kde.org/r/102387/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any &quot;progress&quot; \
on this (ie. &quot;is arthur done?&quot;) KWin could use some more dbus hooks for \
status inspection.</pre>  <br />

<p>- Thomas</p>

<br />
<p>On August 20th, 2011, 2:37 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Arthur Arlt.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 20, 2011, 2:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It annoys me from time to time that I do not know whether kwin uses \
OpenGL or falls back to XRender (e.g. on tablet). So this ends the problem by just \
asking on DBus.

I will wait with committing till Arthur finished the last bit of splitting out the \
Workspace methods in composite into a Compositor class and will then export a new \
Object /Compositor on the DBus interface.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* kwin_gles returns OpenGL ES 2.0
* kwin returns OpenGL 2.x
* No Compositing returns No Compositing
* XRender I assume returns XRender.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(2b8ea6f)</span></li>

 <li>kwin/org.kde.KWin.xml <span style="color: grey">(bd993ed)</span></li>

 <li>kwin/scene.h <span style="color: grey">(6ce39c0)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(600ae2e)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: grey">(4e232c2)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: grey">(06a7b0a)</span></li>

 <li>kwin/scene_xrender.h <span style="color: grey">(6c916c8)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(73dd22f)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(2cba848)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102387/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 