'Re: Review Request: Lower/Raise window opacity with modifier+mouse'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Lower/Raise window opacity with modifier+mouse
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-08-20 12:21:36
Message-ID: 20110820122136.19312.96606 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Aug. 20, 2011, 12:01 p.m., Thomas L=C3=BCbking wrote:
> > Errm... tbh:
> > I guess that I had sth. cooler in mind - where alt+clicking a window wo=
uld initialize the opacity change (just as the moveResize right now...) and=
 moving the pointer would cause the changes. (this way you loose only one b=
utton for the task)
> > =

> > Want me to write a patch?

Ah I did not get that from your mail :-) That sounds tricky, but let's see =
the patch

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102377/#review5835
-----------------------------------------------------------

On Aug. 19, 2011, 8:51 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102377/
> -----------------------------------------------------------
> =

> (Updated Aug. 19, 2011, 8:51 p.m.)
> =

> =

> Review request for kwin and Christoph Feck.
> =

> =

> Summary
> -------
> =

> And the third patch to implement the modifier + lmb/rmb as Thomas suggest=
ed.
> =

> =

> Diffs
> -----
> =

>   kwin/kcmkwin/kwinoptions/mouse.cpp 41e0e94 =

>   kwin/options.cpp 6522e44 =

> =

> Diff: http://git.reviewboard.kde.org/r/102377/diff
> =

> =

> Testing
> -------
> =

> works as expected
> =

> =

> Thanks,
> =

> Martin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102377/">http://git.reviewboard.kde.org/r/102377/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 20th, 2011, 12:01 p.m., <b>Thomas \
Lübking</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Errm... tbh: I guess that I had sth. cooler in mind - where alt+clicking \
a window would initialize the opacity change (just as the moveResize right now...) \
and moving the pointer would cause the changes. (this way you loose only one button \
for the task)

Want me to write a patch?</pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah I did not get that \
from your mail :-) That sounds tricky, but let&#39;s see the patch</pre> <br />

<p>- Martin</p>

<br />
<p>On August 19th, 2011, 8:51 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Christoph Feck.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 19, 2011, 8:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">And the third patch to implement the modifier + lmb/rmb as Thomas \
suggested.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as expected</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinoptions/mouse.cpp <span style="color: \
grey">(41e0e94)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(6522e44)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102377/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 