[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fix & cleanup Workspace::setNumberOfDesktops()
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-04-14 21:25:43
Message-ID: 20110414212543.17526.25914 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 3, 2011, 1:28 p.m., Martin Gräßlin wrote:
> >
>
> Thomas Lübking wrote:
> pushed to master, backport pending
>
> Thomas Lübking wrote:
> I've just figured that the patch introduces a (segfaulting) bug because the \
> screenarea is invalidated on every setNumberOfDesktops() and updateClientArea(true) \
> is not called _afterwards_ (revalidatig) what leads to a segfault in clientArea \
> from checkWorkspacePosition if you eg. remove two window containing desktops in a \
> row from the desktopgrid.
> I've pushed a FIXED* version to 4.6 which does NOT exhibit this issue and will \
> (unles veto) push a fix to master tonight or tomorrow.
> *simple flag carrying the former call from the inner block behind the \
> sreenarea.clear() call
done
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100817/#review2342
-----------------------------------------------------------
On March 7, 2011, 5:50 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100817/
> -----------------------------------------------------------
>
> (Updated March 7, 2011, 5:50 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> setNumberOfDesktops is called from the desktopgrid (or pot. other effects) and this \
> code belongs there and not into the config loading also the function included some \
> (probably evolutionary) redundant blocks needs backport - i'm however not sure that \
> this really will fix the bug, it's just overflow prone and the bug likely defers \
> from an overflow (if the claimed Qt bug is none)
>
> This addresses bug 200213.
> http://bugs.kde.org/show_bug.cgi?id=200213
>
>
> Diffs
> -----
>
> kwin/workspace.cpp 61ce2fe
>
> Diff: http://git.reviewboard.kde.org/r/100817/diff
>
>
> Testing
> -------
>
> created desktops w/ desktopgrid, moved windows to the end, removed desktops, w/ & \
> w/o ending the effect in between
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100817/">http://git.reviewboard.kde.org/r/100817/</a>
</td>
</tr>
</table>
<br />
<p>On April 3rd, 2011, 9 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pushed to master, \
backport pending</pre> </blockquote>
<p>On April 13th, 2011, 9:09 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've just figured \
that the patch introduces a (segfaulting) bug because the screenarea is invalidated \
on every setNumberOfDesktops() and updateClientArea(true) is not called _afterwards_ \
(revalidatig) what leads to a segfault in clientArea from checkWorkspacePosition if \
you eg. remove two window containing desktops in a row from the desktopgrid.
I've pushed a FIXED* version to 4.6 which does NOT exhibit this issue and will \
(unles veto) push a fix to master tonight or tomorrow.
*simple flag carrying the former call from the inner block behind the \
sreenarea.clear() call</pre> </blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">done</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 7th, 2011, 5:50 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 7, 2011, 5:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">setNumberOfDesktops is called from the desktopgrid (or pot. other \
effects) and this code belongs there and not into the config loading also the \
function included some (probably evolutionary) redundant blocks needs backport - \
i'm however not sure that this really will fix the bug, it's just overflow \
prone and the bug likely defers from an overflow (if the claimed Qt bug is \
none)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">created desktops w/ desktopgrid, moved windows to the end, removed \
desktops, w/ & w/o ending the effect in between</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=200213">200213</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/workspace.cpp <span style="color: grey">(61ce2fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic