'Re: Review Request: Implement multi head support in kwin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Implement multi head support in kwin
From:       "Alberto Mattea" <alberto () mattea ! info>
Date:       2011-04-14 16:40:33
Message-ID: 20110414164033.3862.74354 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101125/
-----------------------------------------------------------

(Updated April 14, 2011, 4:40 p.m.)

Review request for kwin, Thomas Lübking and Martin Gräßlin.

Summary
-------

This patch implements basic multiscreen support in kwin:
* It now autostarts on all monitors if a multihead configuration is found
* It sets the correct resolution when maximizing on monitors with different
resolutions.

This addresses bug 256242.
    http://bugs.kde.org/show_bug.cgi?id=256242

Diffs
-----

  ksmserver/startup.cpp c349e98 
  kwin/geometry.cpp 7dee292 
  kwin/main.cpp 81d5aef 

Diff: http://git.reviewboard.kde.org/r/101125/diff

Testing
-------

I've tested it with multihead (obviously) and xinerama (to rule out
regressions).

Thanks,

Alberto

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101125/">http://git.reviewboard.kde.org/r/101125/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Thomas Lübking and Martin Gräßlin.</div>
<div>By Alberto Mattea.</div>

<p style="color: grey;"><i>Updated April 14, 2011, 4:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch implements basic multiscreen support in kwin:
* It now autostarts on all monitors if a multihead configuration is found
* It sets the correct resolution when maximizing on monitors with different
resolutions.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve tested it with multihead (obviously) and xinerama (to rule out \
regressions).</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=256242">256242</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/startup.cpp <span style="color: grey">(c349e98)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(7dee292)</span></li>

 <li>kwin/main.cpp <span style="color: grey">(81d5aef)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101125/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 