[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Pimp kwinrules kcm
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-04-14 21:33:30
Message-ID: 20110414213330.17891.49121 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101041/
-----------------------------------------------------------
(Updated April 14, 2011, 9:33 p.m.)
Review request for kwin.
Changes
-------
Here's a "yesnobox" - this may allow us to once replace the radiobuttons by sth. like \
the on/off switch in MacOS / iOS (it's basically a wrapper that provides the relevant \
checkbox stuff on top of to radiobuttons)
Summary
-------
- adds import/export feature*
- allow delayed window detection
- remove abililty to select "override" as window type (instantly segfaults kwin)
- general UI restructure, regrouping & reterming elements and adding some tooltips \
for the "hääähhh??" rules (except tiling, need to figure that myself ;-) + merge \
the first two tabs into one "window matching" + resort the content of the other ones \
into "Size & Position", "Arrangement & Access" and "Appearance & Fixes" - users don't \
know when a rule is a "workaround", "preferences" is quite generic and "geometry" \
reminds my sister of "math? i don't understand that anyway :-(" =)
* im/exporting allows to export various rules into one file and import them from \
there, in doubt replacing existing dupes. it also allows to delete existing rules.
This should enable kwin developers or distros or everyone who understands WM rules \
to ship there own rule set and have the user import it on a general update or \
whatever (maybe we should have some CLI routine so distros can hang this in the \
package updating?)
Diffs (updated)
-----
kwin/kcmkwin/kwinrules/CMakeLists.txt 835caf2
kwin/kcmkwin/kwinrules/detectwidget.h 62a96ef
kwin/kcmkwin/kwinrules/detectwidget.cpp 9ba3f05
kwin/kcmkwin/kwinrules/detectwidget.ui 827ddcd
kwin/kcmkwin/kwinrules/ruleslist.h 4eb0752
kwin/kcmkwin/kwinrules/ruleslist.cpp c0f3b1b
kwin/kcmkwin/kwinrules/ruleslist.ui c1fc88d
kwin/kcmkwin/kwinrules/ruleswidget.cpp b9fe849
kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 84e05c0
kwin/kcmkwin/kwinrules/yesnobox.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101041/diff
Testing
-------
Thanks,
Thomas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101041/">http://git.reviewboard.kde.org/r/101041/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated April 14, 2011, 9:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here's a "yesnobox" - this may allow us to once replace \
the radiobuttons by sth. like the on/off switch in MacOS / iOS (it's basically a \
wrapper that provides the relevant checkbox stuff on top of to radiobuttons)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- adds import/export feature*
- allow delayed window detection
- remove abililty to select "override" as window type (instantly segfaults \
kwin)
- general UI restructure, regrouping & reterming elements and adding some \
tooltips for the "hääähhh??" rules (except tiling, need to figure that \
myself ;-) + merge the first two tabs into one "window matching"
+ resort the content of the other ones into "Size & Position", \
"Arrangement & Access" and "Appearance & Fixes" - users \
don't know when a rule is a "workaround", "preferences" is \
quite generic and "geometry" reminds my sister of "math? i don't \
understand that anyway :-(" =)
* im/exporting allows to export various rules into one file and import them from \
there, in doubt replacing existing dupes. it also allows to delete existing rules.
This should enable kwin developers or distros or everyone who understands WM rules \
to ship there own rule set and have the user import it on a general update or \
whatever (maybe we should have some CLI routine so distros can hang this in the \
package updating?) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwinrules/CMakeLists.txt <span style="color: \
grey">(835caf2)</span></li>
<li>kwin/kcmkwin/kwinrules/detectwidget.h <span style="color: \
grey">(62a96ef)</span></li>
<li>kwin/kcmkwin/kwinrules/detectwidget.cpp <span style="color: \
grey">(9ba3f05)</span></li>
<li>kwin/kcmkwin/kwinrules/detectwidget.ui <span style="color: \
grey">(827ddcd)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleslist.h <span style="color: \
grey">(4eb0752)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleslist.cpp <span style="color: \
grey">(c0f3b1b)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleslist.ui <span style="color: \
grey">(c1fc88d)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(b9fe849)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidgetbase.ui <span style="color: \
grey">(84e05c0)</span></li>
<li>kwin/kcmkwin/kwinrules/yesnobox.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101041/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic