[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix GL_INVALID_OPERATION error when load texture
From: "Jammy Zhou" <jammy.zhou () linaro ! org>
Date: 2011-03-11 1:10:17
Message-ID: 20110311011017.32078.51664 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 10, 2011, 6:54 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > Thanks for trying the implementation on all those different hardware. I=
would never have been able to find those issues ;-)
I'm glad to work on kwin. And I'd like to bring up the whole plasma-desktop=
stack on ARM platform with GLES2. =
- Jammy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100833/#review1889
-----------------------------------------------------------
On March 10, 2011, 10:03 a.m., Jammy Zhou wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100833/
> -----------------------------------------------------------
> =
> (Updated March 10, 2011, 10:03 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> When run kwin-gles2 on Freescale imx51 ARM platform, GL_INVALID_OPERATION=
error happens in SceneOpenGL::Texture::load(), caused by NULL pixmap passe=
d in. And it happens for QPixmap without X11 pixmap. I can see many warning=
s "QPixmap::handle(): Pixmap is not an X11 class pixmap" when run kwin on i=
mx51.
> =
> =
> Diffs
> -----
> =
> kwin/scene_opengl.cpp 1070081 =
> kwin/scene_opengl_egl.cpp 4f456cb =
> =
> Diff: http://git.reviewboard.kde.org/r/100833/diff
> =
> =
> Testing
> -------
> =
> No GL_INVALID_OPERATION errors in SceneOpenGL::Texture::load() function
> =
> =
> Thanks,
> =
> Jammy
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100833/">http://git.reviewboard.kde.org/r/100833/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 10th, 2011, 6:54 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for trying the implementation on all those different hardware. I \
would never have been able to find those issues ;-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm glad to work on \
kwin. And I'd like to bring up the whole plasma-desktop stack on ARM platform \
with GLES2. </pre> <br />
<p>- Jammy</p>
<br />
<p>On March 10th, 2011, 10:03 a.m., Jammy Zhou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Jammy Zhou.</div>
<p style="color: grey;"><i>Updated March 10, 2011, 10:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When run kwin-gles2 on Freescale imx51 ARM platform, \
GL_INVALID_OPERATION error happens in SceneOpenGL::Texture::load(), caused by NULL \
pixmap passed in. And it happens for QPixmap without X11 pixmap. I can see many \
warnings "QPixmap::handle(): Pixmap is not an X11 class pixmap" when run \
kwin on imx51.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No GL_INVALID_OPERATION errors in SceneOpenGL::Texture::load() \
function</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scene_opengl.cpp <span style="color: grey">(1070081)</span></li>
<li>kwin/scene_opengl_egl.cpp <span style="color: grey">(4f456cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100833/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic