From kwin Fri Mar 11 01:10:17 2011 From: "Jammy Zhou" Date: Fri, 11 Mar 2011 01:10:17 +0000 To: kwin Subject: Re: Review Request: Fix GL_INVALID_OPERATION error when load texture Message-Id: <20110311011017.32078.51664 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129980585008899 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1331847130==" --===============1331847130== Content-Type: multipart/alternative; boundary="===============4198058633318371966==" --===============4198058633318371966== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 10, 2011, 6:54 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > Thanks for trying the implementation on all those different hardware. I= would never have been able to find those issues ;-) I'm glad to work on kwin. And I'd like to bring up the whole plasma-desktop= stack on ARM platform with GLES2. = - Jammy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100833/#review1889 ----------------------------------------------------------- On March 10, 2011, 10:03 a.m., Jammy Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100833/ > ----------------------------------------------------------- > = > (Updated March 10, 2011, 10:03 a.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > When run kwin-gles2 on Freescale imx51 ARM platform, GL_INVALID_OPERATION= error happens in SceneOpenGL::Texture::load(), caused by NULL pixmap passe= d in. And it happens for QPixmap without X11 pixmap. I can see many warning= s "QPixmap::handle(): Pixmap is not an X11 class pixmap" when run kwin on i= mx51. > = > = > Diffs > ----- > = > kwin/scene_opengl.cpp 1070081 = > kwin/scene_opengl_egl.cpp 4f456cb = > = > Diff: http://git.reviewboard.kde.org/r/100833/diff > = > = > Testing > ------- > = > No GL_INVALID_OPERATION errors in SceneOpenGL::Texture::load() function > = > = > Thanks, > = > Jammy > = > --===============4198058633318371966== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100833/

On March 10th, 2011, 6:54 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:

Thanks fo=
r trying the implementation on all those different hardware. I would never =
have been able to find those issues ;-)
I'm gla=
d to work on kwin. And I'd like to bring up the whole plasma-desktop st=
ack on ARM platform with GLES2.

- Jammy


On March 10th, 2011, 10:03 a.m., Jammy Zhou wrote:

Review request for kwin.
By Jammy Zhou.

Updated March 10, 2011, 10:03 a.m.

Descripti= on 

When run kwin-gles2 on Freescale imx51 ARM platform, GL_INVA=
LID_OPERATION error happens in SceneOpenGL::Texture::load(), caused by NULL=
 pixmap passed in. And it happens for QPixmap without X11 pixmap. I can see=
 many warnings "QPixmap::handle(): Pixmap is not an X11 class pixmap&q=
uot; when run kwin on imx51.

Testing <= /h1> 
No GL_INVALID_OPERATION errors in SceneOpenGL::Texture::load=
() function

Diffs=

  • kwin/scene_opengl.cpp (1070081)
  • kwin/scene_opengl_egl.cpp (4f456cb)=

View Diff
--===============4198058633318371966==-- --===============1331847130== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1331847130==--