[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: strip down shortcut code
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-03-10 17:58:03
Message-ID: 20110310175803.14564.69543 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 6, 2011, 7:42 a.m., Martin Gräßlin wrote:
> > kwin/kwinbindings.cpp, line 196
> > <http://git.reviewboard.kde.org/r/100797/diff/1/?file=10574#file10574line196>
> >
> > here as well <=7
or just "< 8" - unless we oc intend for fp dekstops later on ;-)
counting [0-7] is actually correct, no idea why we count c once an human otherwise \
*shrug*
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100797/#review1798
-----------------------------------------------------------
On March 6, 2011, 9:48 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100797/
> -----------------------------------------------------------
>
> (Updated March 6, 2011, 9:48 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> code cleanup - later on this should allow us dynamic shortcut adding/binding (so \
> you won't be limited to twenty desktops or get them presented while you've only 4 - \
> but i need to figure how to get kglobalaccel synced at runtime...)
>
> Diffs
> -----
>
> kwin/kwinbindings.cpp 0a2c1fc
> kwin/useractions.cpp 2cf21b8
> kwin/workspace.h fe97c77
> kwin/workspace.cpp 922de17
>
> Diff: http://git.reviewboard.kde.org/r/100797/diff
>
>
> Testing
> -------
>
> desktop switching still worked.
> you'll maybe have to restart kglobalaccel after installing this patch.
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100797/">http://git.reviewboard.kde.org/r/100797/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 6th, 2011, 7:42 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100797/diff/1/?file=10574#file10574line196" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kwinbindings.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">DEF(I18N_NOOP("Window to Screen 2"), 0, \
slotWindowToScreen2());</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">for (int i = 0; i < 8; ++i) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">173</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">DEF</span><span class="p">(</span><span class="n">I18N_NOOP</span><span \
class="p">(</span><span class="s">"Window to Screen 1"</span><span \
class="p">),</span> <span class="mi">0</span><span class="p">,</span> \
<span class="n">slotWindowToScreen1</span><span class="p">());</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">164</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">for</span> <span class="p">(</span><span class="kt">int</span> <span \
class="n">i</span> <span class="o">=</span> <span class="mi">0</span><span \
class="p">;</span> <span class="n">i</span> <span class="o"><</span> <span \
class="mi">8</span><span class="p">;</span> <span class="o">++</span><span \
class="n">i</span><span class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here as well \
<=7</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">or just \
"< 8" - unless we oc intend for fp dekstops later on ;-) counting [0-7] \
is actually correct, no idea why we count c once an human otherwise *shrug* </pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 6th, 2011, 9:48 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 6, 2011, 9:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">code cleanup - later on this should allow us dynamic shortcut \
adding/binding (so you won't be limited to twenty desktops or get them presented \
while you've only 4 - but i need to figure how to get kglobalaccel synced at \
runtime...)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">desktop switching still worked. you'll maybe have to restart \
kglobalaccel after installing this patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kwinbindings.cpp <span style="color: grey">(0a2c1fc)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(2cf21b8)</span></li>
<li>kwin/workspace.h <span style="color: grey">(fe97c77)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100797/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic