From kwin Thu Mar 10 17:58:03 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 10 Mar 2011 17:58:03 +0000 To: kwin Subject: Re: Review Request: strip down shortcut code Message-Id: <20110310175803.14564.69543 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129977993608753 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1717005715==" --===============1717005715== Content-Type: multipart/alternative; boundary="===============8256368033504524743==" --===============8256368033504524743== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 6, 2011, 7:42 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/kwinbindings.cpp, line 196 > > > > > > here as well <=3D7 or just "< 8" - unless we oc intend for fp dekstops later on ;-) counting [0-7] is actually correct, no idea why we count c once an human ot= herwise *shrug* - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100797/#review1798 ----------------------------------------------------------- On March 6, 2011, 9:48 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100797/ > ----------------------------------------------------------- > = > (Updated March 6, 2011, 9:48 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > code cleanup - later on this should allow us dynamic shortcut adding/bind= ing (so you won't be limited to twenty desktops or get them presented while= you've only 4 - but i need to figure how to get kglobalaccel synced at run= time...) > = > = > Diffs > ----- > = > kwin/kwinbindings.cpp 0a2c1fc = > kwin/useractions.cpp 2cf21b8 = > kwin/workspace.h fe97c77 = > kwin/workspace.cpp 922de17 = > = > Diff: http://git.reviewboard.kde.org/r/100797/diff > = > = > Testing > ------- > = > desktop switching still worked. > you'll maybe have to restart kglobalaccel after installing this patch. > = > = > Thanks, > = > Thomas > = > --===============8256368033504524743== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100797/

On March 6th, 2011, 7:42 a.m., Martin Gr=C3= =A4=C3=9Flin wrote:

= = =
kwin/kwinbindings.cpp (Diff revision 1) 
DEF(I18N_NOOP("Window to Screen 2"),               0, slo=
tWindowToScreen2());
 
for (int i =3D 0; i < 8; ++i) {
173 
DEF=
(I18N_NOOP("Window to Screen 1"),=
               0, slotWindowToScreen1());
164 
for (int i =3D 0; <=
span class=3D"n">i < =
8; ++i) {
<= /td> 
here as w=
ell <=3D7
or just "< 8" - unless we oc intend for fp dekstops lat=
er on ;-)
counting [0-7] is actually correct, no idea why we count c once an human ot=
herwise  *shrug*

- Thomas


On March 6th, 2011, 9:48 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin.
By Thomas L=C3=BCbking.

Updated March 6, 2011, 9:48 p.m.

Descripti= on 

code cleanup - later on this should allow us dynamic shortcu=
t adding/binding (so you won't be limited to twenty desktops or get the=
m presented while you've only 4 - but i need to figure how to get kglob=
alaccel synced at runtime...)

Testing <= /h1> 
desktop switching still worked.
you'll maybe have to restart kglobalaccel after installing this patch.<=
/pre>

Diffs=

  • kwin/kwinbindings.cpp (0a2c1fc)
  • kwin/useractions.cpp (2cf21b8)
  • kwin/workspace.h (fe97c77)
  • kwin/workspace.cpp (922de17)

View Diff
--===============8256368033504524743==-- --===============1717005715== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1717005715==--