'Re: Review Request: strip down shortcut code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: strip down shortcut code
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-03-06 21:48:36
Message-ID: 20110306214836.24428.39405 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100797/
-----------------------------------------------------------

(Updated March 6, 2011, 9:48 p.m.)

Review request for kwin.

Changes
-------

fixes.
a) coding style
b) lame human counting for desktops (we actually count screens from 0-7)
c) secure desktop setting in workspace.cpp (where it belongs) - KWIN_MAX_NU=
MBER_DESKTOPS is a static const int there and also we ultimately want to re=
move it, yesno?

Summary
-------

code cleanup - later on this should allow us dynamic shortcut adding/bindin=
g (so you won't be limited to twenty desktops or get them presented while y=
ou've only 4 - but i need to figure how to get kglobalaccel synced at runti=
me...)

Diffs (updated)
-----

  kwin/kwinbindings.cpp 0a2c1fc =

  kwin/useractions.cpp 2cf21b8 =

  kwin/workspace.h fe97c77 =

  kwin/workspace.cpp 922de17 =

Diff: http://git.reviewboard.kde.org/r/100797/diff

Testing
-------

desktop switching still worked.
you'll maybe have to restart kglobalaccel after installing this patch.

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100797/">http://git.reviewboard.kde.org/r/100797/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 6, 2011, 9:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixes. a) coding style
b) lame human counting for desktops (we actually count screens from 0-7)
c) secure desktop setting in workspace.cpp (where it belongs) - \
KWIN_MAX_NUMBER_DESKTOPS is a static const int there and also we ultimately want to \
remove it, yesno?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">code cleanup - later on this should allow us dynamic shortcut \
adding/binding (so you won&#39;t be limited to twenty desktops or get them presented \
while you&#39;ve only 4 - but i need to figure how to get kglobalaccel synced at \
runtime...)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">desktop switching still worked. you&#39;ll maybe have to restart \
kglobalaccel after installing this patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kwinbindings.cpp <span style="color: grey">(0a2c1fc)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(2cf21b8)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(fe97c77)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100797/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 