[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Patch for bug 174769
From:       "David Nadlinger" <david.nadlinger () gmail ! com>
Date:       2008-11-22 15:59:36
Message-ID: a067f750811220759w448be8dfp65fef07bea74f53c () mail ! gmail ! com
[Download RAW message or body]

> I take the bit about the condition change in my first E-mail back, it
> was changing a different part of the code than I thought it was.
No, you were right, I've changed that in the meantime.

> If you leave the system settings
> dialog open when KWin is reset [...]
> It would be better if it was created only when the
> confirmation window is being displayed and deleted after the settings
> have been applied.
What exactly do you mean by "reset"?
Currently the backup config is created in the KCModule constructor and
deleted in the destructor, which simplifies a few other things
(isConfirmationNeeded() just compares the new and the backup config).
However, writing the file to disk doesn't make any sense, that's
right. I'll see if I can fix that by removing the sync()s and deleting
the backup file after the new settings are confirmed. I'm not quite
sure when KConfig expects the file to be available from disk though.

As for removing the connection to effectSelector#configCommited
resulting in a call to KSettings::Dispatcher::reparseConfiguration, I
have not been able to find anything that would require this. However,
I might as well have missed that piece of code. Do you know why it was
brought in?
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]