[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Patch for bug 174769
From:       "Lucas Murray" <lmurray () undefinedfire ! com>
Date:       2008-11-22 14:31:47
Message-ID: f09827650811220631j337b1c28y753dacc092f62b62 () mail ! gmail ! com
[Download RAW message or body]

I take the bit about the condition change in my first E-mail back, it
was changing a different part of the code than I thought it was.

As for these new ones all patches are fine as far as I can see
standard-wise but I've found a bug: If you leave the system settings
dialog open when KWin is reset it thinks that it crashed even if the
confirmation window was not displayed. It looks like the backup file
is being created when the panel is opened then deleted when the user
leaves. It would be better if it was created only when the
confirmation window is being displayed and deleted after the settings
have been applied.

On Thu, Nov 20, 2008 at 6:24 AM, David Nadlinger
<david.nadlinger@gmail.com> wrote:
> Sorry for the hassle everyone, I was in a hurry when I sent the patch
> (actually, it was 01:45 a.m. and I wanted to go to bed – shouldn't do
> that, I know^^).
>
> The main patch is still quite big, but there are a few changes that
> make it seem messier than it actually is:
> - I have changed the name of mKWinConfig to mNewConfig in order to
> better express the purpose
> - I have split up the loading code in Options::updateSettings into
> subroutines (actually, I have not changed anything except for adding
> the backup related code)
> - I have renamed the "reinitCompositing" DBus signal to
> "reloadCompositingConfig" in order to clarify its purpose
> - As I have mentioned before, it took me several iterations to find a
> solution. Thus, there are a few basically unneeded changes in the
> patch. However, I think they make the code easier to understand, so I
> have not removed them.
>
> The second patch contains a small fix (the dropdown boxes for the
> window/desktop switching effects were not updated correctly if all
> related effects had been disabled) and removes some unused code.
>
> The third patch contains a few comment changes and a lot of whitespace
> changes to make the code comply to the KWin coding standards.
>
> I have just created these three with the help of "git add --patch" and
> had no time to them yet, so the might not be fully independent.
>
> The patches are attached this time, if you prefer a fancy HTML
> rendering, you can still have look at them at
> http://github.com/klickverbot/kwin/commits/configbackup.
> Please bear with me if I have again made some major mistake ;)
>
> _______________________________________________
> kwin mailing list
> kwin@kde.org
> https://mail.kde.org/mailman/listinfo/kwin
>
>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]