[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: kwin wobbly windows resize patch
From:       Cédric_Borgese <cedric.borgese () gmail ! com>
Date:       2008-11-22 15:45:25
Message-ID: 200811221744.23750.cedric.borgese () gmail ! com
[Download RAW message or body]


I didn't tested it yet, but the patch looks good except line 1070, you set the 
position of each constrained point to its original position. this has at least 
twos effects :

1) the picked point is constrained, so if you force it to its original value, 
it will exactly follow the mouse and you'll be unable to set the parameter to 
have a window slower than the mouse mouse that "follow" the pointer.

2) as the acceleration of a constrained point is calculated with the distance  
between its original position and its new position, for a point that doesn't 
move, the acceleration is 0 and so the point doesn't wobble.

So I suggest to remove the changes from line 1067 to 1073

On Saturday 22 November 2008 15:10:46 Lucas Murray wrote:
> The patch is good, except if the user decides to resize a side instead
> of a corner. Do you have a Subversion account? If not resubmit the
> updated patch and I'll commit it to trunk for you.
>
> On Fri, Nov 21, 2008 at 8:31 AM, Toby Dickenson <toby@tarind.com> wrote:
> > Hello all,
> >
> > Attached is a patch for wobblywindows.cpp. This makes the window resize
> > operation smoother by constraining the position of the opposite corner of
> > the window. The window still wobbles in the middle while the edges remain
> > calm.
> >
> > Without this patch the opposite sides vibrate franticly during resize.
> > Annoying, and making it difficult to see the new size of your window
> > without waiting for the wobble to settle.
> >
> > This is my first kde patch for a few years, and my first for kde4.
> >
> > --
> >
> > Toby Dickenson
> >
> > _______________________________________________
> > kwin mailing list
> > kwin@kde.org
> > https://mail.kde.org/mailman/listinfo/kwin
>
> _______________________________________________
> kwin mailing list
> kwin@kde.org
> https://mail.kde.org/mailman/listinfo/kwin

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]