[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: wobbly effect
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2008-02-25 10:32:11
Message-ID: 200802251132.12467.l.lunak () suse ! cz
[Download RAW message or body]

On st 20. února 2008, cedric wrote:
> the patch was too big, resend a bzipped one.

 Comments from reading through the sources:

- I think copyright headers should say more than just "Copyright (C) 
2007" :) , the same about the .desktop files
- test subdirectory is not meant to be enabled in SVN, if you want to keep 
this effect there, you'll need to keep it enabled only locally
- "#if defined COMPUTE_STATS and not defined VERBOSE_MODE" - I think some 
compilers don't like keywords like "and" and "not", so please use &&, !
- #warning is gcc-ism, so it needs to be enclosed in "#ifdef __GNUC__"
- "// Could we just set a subset of the screen to be repainted ?" - yes, you 
can alter it in ScreenPrePaintData, see e.g. ShadowEffect::prePaintWindow()

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]