[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: GetFBConfigs
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2007-01-30 11:52:43
Message-ID: 200701301252.43495.l.lunak () suse ! cz
[Download RAW message or body]

On Monday 29 January 2007 22:36, Philip Falkner wrote:
> On Monday 29 January 2007 10:21, Lubos Lunak wrote:
> > On Saturday 27 January 2007 21:26, Philip Falkner wrote:
> Attached patch again.  I've split initFBConfigs() into initBufferConfigs()
> and initDrawableConfigs() for neatness.  Since Rivo's problem is something
> unrelated to this, commit?

 Yes, with one problem. Fdclock -sta now is not transparent for me in TFP 
mode. It seems that even non-32-bit configs can have BIND_TO_TEXTURE_RGBA, 
the problem is fixed here when I remove the "if( i == 32 )" in 
SceneOpenGL::initDrawableConfigs(). Do you have the same? I'm rather confused 
by this, Compiz has the same check, it however works here only with Xgl.

> > > >  Although unlikely, I think texture_y_inverted could be different for
> > > > different depths. And we only have a global flag that is later used in
> > > > performPaint().
> > > Yes, but glXGetFBConfigAttrib() will query
> > > fbcdrawable[toplevel->depth()], and since texture_y_inverted is stored
> > > in Window, different windows with different depths could happily have
> > > different y-inversions, couldn't they? 

 Ah, grmbl, of course you're right. I mistakenly thought texture_y_inverted 
was global in SceneOpenGL, not in Window.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]