[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: GetFBConfigs
From:       Philip Falkner <philip.falkner () gmail ! com>
Date:       2007-01-30 17:10:15
Message-ID: 200701301210.15568.philip.falkner () gmail ! com
[Download RAW message or body]

On Tuesday 30 January 2007 06:52, Lubos Lunak wrote:
> On Monday 29 January 2007 22:36, Philip Falkner wrote:
> >
> > Attached patch again.  I've split initFBConfigs() into
> > initBufferConfigs() and initDrawableConfigs() for neatness.  Since Rivo's
> > problem is something unrelated to this, commit?
>
>  Yes, with one problem. Fdclock -sta now is not transparent for me in TFP
> mode. It seems that even non-32-bit configs can have BIND_TO_TEXTURE_RGBA,
> the problem is fixed here when I remove the "if( i == 32 )" in
> SceneOpenGL::initDrawableConfigs(). Do you have the same? I'm rather
> confused by this, Compiz has the same check, it however works here only
> with Xgl.

fdclock -sta works fine here in tfp, and only the one 32-bit config has 
BIND_TO_TEXTURE_RGBA.  But it shouldn't even check for RGBA except on 32-bit 
configs; I just double-checked and that's how it works here.  Could you tell 
me which configs it's selecting for you?

-- 
Philip Falkner

["configtest.patch" (text/x-diff)]

--- scene_opengl.cpp.orig	2007-01-30 12:02:15.000000000 -0500
+++ scene_opengl.cpp	2007-01-30 12:02:01.000000000 -0500
@@ -446,13 +446,19 @@ bool SceneOpenGL::initDrawableConfigs()
                 continue;
             if( tfp_mode )
                 {
+                int tmp;
+                glXGetFBConfigAttrib( display(), fbconfigs[ j ],
+                                      GLX_VISUAL_ID, &tmp );
+                kDebug() << "Checking config 0x" << QString::number( tmp, 16 ) << endl;
                 value = 0;
                 if( i == 32 )
                     {
+                    kDebug() << "RGBA?" << endl;
                     glXGetFBConfigAttrib( display(), fbconfigs[ j ],
                                           GLX_BIND_TO_TEXTURE_RGBA_EXT, &value );
                     if( value )
                         {
+                        kDebug() << "Yes" << endl;
                         rgba = 1;
                         fbcdrawableinfo[ i ].bind_texture_format = GLX_TEXTURE_FORMAT_RGBA_EXT;
                         }
@@ -461,10 +467,12 @@ bool SceneOpenGL::initDrawableConfigs()
                     {
                     if( rgba )
                         continue;
+                    kDebug() << "RGB?" << endl;
                     glXGetFBConfigAttrib( display(), fbconfigs[ j ],
                                           GLX_BIND_TO_TEXTURE_RGB_EXT, &value );
                     if( !value )
                         continue;
+                    kDebug() << "Yes" << endl;
                     fbcdrawableinfo[ i ].bind_texture_format = GLX_TEXTURE_FORMAT_RGB_EXT;
                     }
                 }


_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]