'Re: Review Request: Group Offline contacts into a separate group "Offline Users"'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Group Offline contacts into a separate group "Offline Users"
From:       "Lamarque Souza" <lamarque () kde ! org>
Date:       2012-02-26 17:05:53
Message-ID: 20120226170553.32488.47805 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On July 4, 2010, 2:14 a.m., Raphael Kubo da Costa wrote:
> > Well, nobody has given a NACK yet, so I presume this is a tacit ACK :)
> > =

> > Does this patch still apply fine to trunk? It'd be good to apply it now=
 that trunk is unfrozen for SC 4.6.
> =

> Lamarque Souza wrote:
>     Well, I tried the updated patch from Pali Roh=C3=A1r but it does not =
work here. I have got the option "Show offline users in a separated folder"=
 but no "Offline" folder was created. By the way, we should change that str=
ing to "Show offline users in a separated group", we use the word "group" e=
verywhere in the source code, not "folder".
> =

> Lamarque Souza wrote:
>     Ops, it works, I had to toggle the show/hide offline users to activat=
e it. Hmmm it's not that intuitive, but anyway, I will commit it.

Pushed, please close this review request since svn is not doing it for me.

- Lamarque

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/2179/#review6362
-----------------------------------------------------------

On Nov. 18, 2009, 4:12 a.m., Barry Carter wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/2179/
> -----------------------------------------------------------
> =

> (Updated Nov. 18, 2009, 4:12 a.m.)
> =

> =

> Review request for Kopete.
> =

> =

> Description
> -------
> =

> This patch allows a new configuration option to be set which will show al=
l offline users grouped into a folder called "Offline Users".
> =

> When a contact comes online, the metacontact is removed from the offline =
group, and added to the normal group folder. Likewise when the contact goes=
 offline, the contact is added to the offline users folder.
> =

> Rules: =

> If "Show Offline" is set, then the offline folder group is removed from v=
iew.
> If a search is in progress, the offline folder is removed from view.
> Using the proxyfilter lessThan, the Offline folder is always pushed to th=
e bottom of the list.
> =

> Protection:
> Removed right click access to the folder so no renaming etc can be done (=
wise?).
> Removed ability for a user to move a contact to the offline folder.
> =

> Side Effects:
> The offline users folder is always visible even when not connected to a n=
etwork.
> =

> Implementation:
> The offline folder is a "special" group like temporary or toplevel. This =
allows it to hide away from the group menus while still being filterable.
> =

> Future:
> Assuming anyone is interested in this feature, there are a couple of cosm=
etic changes that might be made. One is... The offline folder will never ha=
ve an online contact, so instead of showing "Offline Users (0/1000)" it cou=
ld be abbreviated to "Offline Users (1000)"
> =

> Questions:
> If we simply call the folder "Offline" would we get better i18n?
> Is there a better way to do this?
> =

> built against 0.80.2
> =

> =

> Diffs
> -----
> =

>   /branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearance=
config_contactlist.ui 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxy=
model.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttreem=
odel.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactlis=
tview.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdelega=
te.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopetecontact=
liststorage.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontactsto=
rage.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings.=
kcfg 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp 104=
6954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp 1046954 =

>   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 104=
6954 =

> =

> Diff: http://svn.reviewboard.kde.org/r/2179/diff/
> =

> =

> Testing
> -------
> =

> Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/
> =

> =

> Screenshots
> -----------
> =

> Offline Users
>   http://svn.reviewboard.kde.org/r/2179/s/262/
> Show offline contacts in a separate folder
>   http://svn.reviewboard.kde.org/r/2179/s/265/
> Offline Users cleanup
>   http://svn.reviewboard.kde.org/r/2179/s/266/
> =

> =

> Thanks,
> =

> Barry Carter
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/2179/">http://svn.reviewboard.kde.org/r/2179/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 4th, 2010, 2:14 a.m., <b>Raphael Kubo da \
Costa</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Well, nobody has given a NACK yet, so I presume this is a tacit ACK :)

Does this patch still apply fine to trunk? It&#39;d be good to apply it now that \
trunk is unfrozen for SC 4.6.</pre>  </blockquote>

 <p>On February 26th, 2012, 4:59 p.m., <b>Lamarque Souza</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I tried the \
updated patch from Pali Rohár but it does not work here. I have got the option \
&quot;Show offline users in a separated folder&quot; but no &quot;Offline&quot; \
folder was created. By the way, we should change that string to &quot;Show offline \
users in a separated group&quot;, we use the word &quot;group&quot; everywhere in the \
source code, not &quot;folder&quot;.</pre>  </blockquote>

 <p>On February 26th, 2012, 5:04 p.m., <b>Lamarque Souza</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ops, it works, I had to \
toggle the show/hide offline users to activate it. Hmmm it&#39;s not that intuitive, \
but anyway, I will commit it.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pushed, please close \
this review request since svn is not doing it for me.</pre> <br />

<p>- Lamarque</p>

<br />
<p>On November 18th, 2009, 4:12 a.m., Barry Carter wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Barry Carter.</div>

<p style="color: grey;"><i>Updated Nov. 18, 2009, 4:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows a new configuration option to be set which will show \
all offline users grouped into a folder called &quot;Offline Users&quot;.

When a contact comes online, the metacontact is removed from the offline group, and \
added to the normal group folder. Likewise when the contact goes offline, the contact \
is added to the offline users folder.

Rules: 
If &quot;Show Offline&quot; is set, then the offline folder group is removed from \
view. If a search is in progress, the offline folder is removed from view.
Using the proxyfilter lessThan, the Offline folder is always pushed to the bottom of \
the list.

Protection:
Removed right click access to the folder so no renaming etc can be done (wise?).
Removed ability for a user to move a contact to the offline folder.

Side Effects:
The offline users folder is always visible even when not connected to a network.

Implementation:
The offline folder is a &quot;special&quot; group like temporary or toplevel. This \
allows it to hide away from the group menus while still being filterable.

Future:
Assuming anyone is interested in this feature, there are a couple of cosmetic changes \
that might be made. One is... The offline folder will never have an online contact, \
so instead of showing &quot;Offline Users (0/1000)&quot; it could be abbreviated to \
&quot;Offline Users (1000)&quot;

Questions:
If we simply call the folder &quot;Offline&quot; would we get better i18n?
Is there a better way to do this?

built against 0.80.2</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_contactlist.ui \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopetecontactliststorage.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg \
<span style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp <span \
style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h <span style="color: \
grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp <span \
style="color: grey">(1046954)</span></li>

 <li>/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp <span \
style="color: grey">(1046954)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/2179/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/2179/s/262/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2009/11/15/newKopeteOfflineGroup_400x100.png" \
style="border: 1px black solid;" alt="Offline Users" /></a>

 <a href="http://svn.reviewboard.kde.org/r/2179/s/265/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2009/11/17/kopeteofflinegroupedsettings_400x100.png" \
style="border: 1px black solid;" alt="Show offline contacts in a separate folder" \
/></a>

 <a href="http://svn.reviewboard.kde.org/r/2179/s/266/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2009/11/18/kopeteImageOfflineCleanup_400x100.png" \
style="border: 1px black solid;" alt="Offline Users cleanup" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 