This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/2179/

On July 4th, 2010, 2:14 a.m., Raphael Kubo da Costa wrote:

Well, nobody has given a NACK yet, so I presume this is a tacit ACK :)

Does this patch still apply fine to trunk? It'd be good to apply it now that trunk is unfrozen for SC 4.6.

On February 26th, 2012, 4:59 p.m., Lamarque Souza wrote:

Well, I tried the updated patch from Pali Rohár but it does not work here. I have got the option "Show offline users in a separated folder" but no "Offline" folder was created. By the way, we should change that string to "Show offline users in a separated group", we use the word "group" everywhere in the source code, not "folder".

On February 26th, 2012, 5:04 p.m., Lamarque Souza wrote:

Ops, it works, I had to toggle the show/hide offline users to activate it. Hmmm it's not that intuitive, but anyway, I will commit it.
Pushed, please close this review request since svn is not doing it for me.

- Lamarque


On November 18th, 2009, 4:12 a.m., Barry Carter wrote:

Review request for Kopete.
By Barry Carter.

Updated Nov. 18, 2009, 4:12 a.m.

Description 

This patch allows a new configuration option to be set which will show all offline users grouped into a folder called "Offline Users".

When a contact comes online, the metacontact is removed from the offline group, and added to the normal group folder. Likewise when the contact goes offline, the contact is added to the offline users folder.

Rules: 
If "Show Offline" is set, then the offline folder group is removed from view.
If a search is in progress, the offline folder is removed from view.
Using the proxyfilter lessThan, the Offline folder is always pushed to the bottom of the list.

Protection:
Removed right click access to the folder so no renaming etc can be done (wise?).
Removed ability for a user to move a contact to the offline folder.

Side Effects:
The offline users folder is always visible even when not connected to a network.

Implementation:
The offline folder is a "special" group like temporary or toplevel. This allows it to hide away from the group menus while still being filterable.

Future:
Assuming anyone is interested in this feature, there are a couple of cosmetic changes that might be made. One is... The offline folder will never have an online contact, so instead of showing "Offline Users (0/1000)" it could be abbreviated to "Offline Users (1000)"

Questions:
If we simply call the folder "Offline" would we get better i18n?
Is there a better way to do this?

built against 0.80.2

Testing 

Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/

Diffs

  • /branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_contactlist.ui (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopetecontactliststorage.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp (1046954)
  • /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp (1046954)

View Diff

Screenshots

Offline Users Show offline contacts in a separate folder Offline Users cleanup