This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/2179/

On July 4th, 2010, 2:14 a.m., Raphael Kubo = da Costa wrote:

Well, nob=
ody has given a NACK yet, so I presume this is a tacit ACK :)

Does this patch still apply fine to trunk? It'd be good to apply it now=
 that trunk is unfrozen for SC 4.6.

On February 26th, 2012, 4:59 p.m., Lamarque Souza wrote:

Well, I t=
ried the updated patch from Pali Roh=C3=A1r but it does not work here. I ha=
ve got the option "Show offline users in a separated folder" but =
no "Offline" folder was created. By the way, we should change tha=
t string to "Show offline users in a separated group", we use the=
 word "group" everywhere in the source code, not "folder&quo=
t;.

On February 26th, 2012, 5:04 p.m., Lamarque Souza wrote:

Ops, it w=
orks, I had to toggle the show/hide offline users to activate it. Hmmm it&#=
39;s not that intuitive, but anyway, I will commit it.

Pushed, ple=
ase close this review request since svn is not doing it for me.

- Lamarque

On November 18th, 2009, 4:12 a.m., Barry Carter wrote:

Review request for Kopete.

By Barry Carter.

Updated Nov. 18, 2009, 4:12 a.m.

Descripti= on

This patch allows a new configuration option to be set which=
 will show all offline users grouped into a folder called "Offline Use=
rs".

When a contact comes online, the metacontact is removed from the offline gr=
oup, and added to the normal group folder. Likewise when the contact goes o=
ffline, the contact is added to the offline users folder.

Rules: =

If "Show Offline" is set, then the offline folder group is remove=
d from view.
If a search is in progress, the offline folder is removed from view.
Using the proxyfilter lessThan, the Offline folder is always pushed to the =
bottom of the list.

Protection:
Removed right click access to the folder so no renaming etc can be done (wi=
se?).
Removed ability for a user to move a contact to the offline folder.

Side Effects:
The offline users folder is always visible even when not connected to a net=
work.

Implementation:
The offline folder is a "special" group like temporary or topleve=
l. This allows it to hide away from the group menus while still being filte=
rable.

Future:
Assuming anyone is interested in this feature, there are a couple of cosmet=
ic changes that might be made. One is... The offline folder will never have=
 an online contact, so instead of showing "Offline Users (0/1000)"=
; it could be abbreviated to "Offline Users (1000)"

Questions:
If we simply call the folder "Offline" would we get better i18n?
Is there a better way to do this?

built against 0.80.2

Testing <= /h1>

Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/

Diffs=

/branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearanc= econfig_contactlist.ui (1046954)
/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistprox= ymodel.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttree= model.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactli= stview.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdeleg= ate.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopetecontac= tliststorage.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontactst= orage.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings= .kcfg (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp (1046954)
/branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp (1046954)

View Diff

Screensho= ts