[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Some fixes for cryptography plugin
From: "Lamarque Souza" <lamarque () kde ! org>
Date: 2012-02-26 12:55:38
Message-ID: 20120226125538.16456.5466 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 26, 2012, 11:52 a.m., Lamarque Souza wrote:
> > trunk/extragear/network/kopete-cryptography/cryptographyplugin.h, line 89
> > <http://svn.reviewboard.kde.org/r/6768/diff/1/?file=46792#file46792line89>
> >
> > Do you know if this plugin really works with all those protocols? If so then this \
> > patch is good to go in my oppinion.
>
> Pali Rohár wrote:
> This plugin send PGP signed/encrypted message via standard protocol. So user who \
> not using kopete with this plugin will get message like:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> test message
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
>
> iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP
> HZMAoMbCNard1YocYfceOgU/sSOk+1Ng
> =KvtM
> -----END PGP SIGNATURE-----
>
> The only problem is if protocol support long messages. And all these protocols \
> should support long messages. Only problematic protocol is ICQ, which is disabled.
Ok the. Patch pushed. Please close this review since svn is not doing it \
automatically.
http://websvn.kde.org/?view=revision&revision=1282282
- Lamarque
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6768/#review10703
-----------------------------------------------------------
On Aug. 20, 2011, 8:59 a.m., Pali Rohár wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6768/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2011, 8:59 a.m.)
>
>
> Review request for Kopete.
>
>
> Description
> -------
>
> This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported protocol lists \
> and update information box about unsupported protocol.
>
> Diffs
> -----
>
> trunk/extragear/network/kopete-cryptography/CMakeLists.txt 1248234
> trunk/extragear/network/kopete-cryptography/cryptographyplugin.h 1248234
> trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1248234
>
> Diff: http://svn.reviewboard.kde.org/r/6768/diff/
>
>
> Testing
> -------
>
> Patch working for me fine.
>
>
> Thanks,
>
> Pali Rohár
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6768/">http://svn.reviewboard.kde.org/r/6768/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 26th, 2012, 11:52 a.m., <b>Lamarque \
Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6768/diff/1/?file=46792#file46792line89" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/extragear/network/kopete-cryptography/cryptographyplugin.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
CryptographyPlugin : public Kopete::Plugin</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">89</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span> <span \
class="o"><<</span> <span class="s">"WLMProtocol"</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you know if this \
plugin really works with all those protocols? If so then this patch is good to go in \
my oppinion.</pre> </blockquote>
<p>On February 26th, 2012, noon, <b>Pali Rohár</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This plugin send PGP \
signed/encrypted message via standard protocol. So user who not using kopete with \
this plugin will get message like:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
test message
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP
HZMAoMbCNard1YocYfceOgU/sSOk+1Ng
=KvtM
-----END PGP SIGNATURE-----
The only problem is if protocol support long messages. And all these protocols should \
support long messages. Only problematic protocol is ICQ, which is disabled.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok the. \
Patch pushed. Please close this review since svn is not doing it automatically.
http://websvn.kde.org/?view=revision&revision=1282282</pre>
<br />
<p>- Lamarque</p>
<br />
<p>On August 20th, 2011, 8:59 a.m., Pali Rohár wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2011, 8:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported \
protocol lists and update information box about unsupported protocol.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch working for me fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/network/kopete-cryptography/CMakeLists.txt <span style="color: \
grey">(1248234)</span></li>
<li>trunk/extragear/network/kopete-cryptography/cryptographyplugin.h <span \
style="color: grey">(1248234)</span></li>
<li>trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp <span \
style="color: grey">(1248234)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6768/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic