On February 26th, 2012, 11:52 a.m., Lamarque Souza wrote:

trunk/extragear/network/kopete-cryptography/cryptographyplugin.h (Diff revision 1)
class CryptographyPlugin : public Kopete::Plugin
		89	<< "WLMProtocol"

Do you know if this plugin really works with all those protocols? If so then this patch is good to go in my oppinion.

On February 26th, 2012, noon, Pali Rohár wrote:

This plugin send PGP signed/encrypted message via standard protocol. So user who not using kopete with this plugin will get message like:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

test message
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP
HZMAoMbCNard1YocYfceOgU/sSOk+1Ng
=KvtM
-----END PGP SIGNATURE-----

The only problem is if protocol support long messages. And all these protocols should support long messages. Only problematic protocol is ICQ, which is disabled.

Ok the. Patch pushed. Please close this review since svn is not doing it automatically.

http://websvn.kde.org/?view=revision&revision=1282282

- Lamarque

On August 20th, 2011, 8:59 a.m., Pali Rohár wrote:

This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported protocol lists and update information box about unsupported protocol.

Patch working for me fine.