From kopete-devel Sun Feb 26 12:55:38 2012 From: "Lamarque Souza" Date: Sun, 26 Feb 2012 12:55:38 +0000 To: kopete-devel Subject: Re: Review Request: Some fixes for cryptography plugin Message-Id: <20120226125538.16456.5466 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kopete-devel&m=133026098110764 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6974571045196255717==" --===============6974571045196255717== Content-Type: multipart/alternative; boundary="===============2055917289656735103==" --===============2055917289656735103== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 26, 2012, 11:52 a.m., Lamarque Souza wrote: > > trunk/extragear/network/kopete-cryptography/cryptographyplugin.h, line = 89 > > > > > > Do you know if this plugin really works with all those protocols? I= f so then this patch is good to go in my oppinion. > = > Pali Roh=C3=A1r wrote: > This plugin send PGP signed/encrypted message via standard protocol. = So user who not using kopete with this plugin will get message like: > = > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > = > test message > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > = > iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP > HZMAoMbCNard1YocYfceOgU/sSOk+1Ng > =3DKvtM > -----END PGP SIGNATURE----- > = > The only problem is if protocol support long messages. And all these = protocols should support long messages. Only problematic protocol is ICQ, w= hich is disabled. Ok the. Patch pushed. Please close this review since svn is not doing it au= tomatically. http://websvn.kde.org/?view=3Drevision&revision=3D1282282 - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6768/#review10703 ----------------------------------------------------------- On Aug. 20, 2011, 8:59 a.m., Pali Roh=C3=A1r wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6768/ > ----------------------------------------------------------- > = > (Updated Aug. 20, 2011, 8:59 a.m.) > = > = > Review request for Kopete. > = > = > Description > ------- > = > This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported prot= ocol lists and update information box about unsupported protocol. > = > = > Diffs > ----- > = > trunk/extragear/network/kopete-cryptography/CMakeLists.txt 1248234 = > trunk/extragear/network/kopete-cryptography/cryptographyplugin.h 124823= 4 = > trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1248= 234 = > = > Diff: http://svn.reviewboard.kde.org/r/6768/diff/ > = > = > Testing > ------- > = > Patch working for me fine. > = > = > Thanks, > = > Pali Roh=C3=A1r > = > --===============2055917289656735103== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6768/

On February 26th, 2012, 11:52 a.m., Lamarqu= e Souza wrote:

= = =
trunk/extragear/network/kopete-cryptography/cryptographyplugin.= h (Diff revision 1) 
class CryptographyPlugin : public Kopete::Plugin
 

    89
    
	=
		       <<=
 "WLMProtocol"

  


 




  
Do you kn=
ow if this plugin really works with all those protocols? If so then this pa=
tch is good to go in my oppinion.

 




 
On February 26th, 2012, noon, Pali Roh=C3=A1r wrote:

 

  
This plug=
in send PGP signed/encrypted message via standard protocol. So user who not=
 using kopete with this plugin will get message like:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

test message
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP
HZMAoMbCNard1YocYfceOgU/sSOk+1Ng
=3DKvtM
-----END PGP SIGNATURE-----

The only problem is if protocol support long messages. And all these protoc=
ols should support long messages. Only problematic protocol is ICQ, which i=
s disabled.

 











Ok the. Patch pushed. Please close this review since svn is not doin=
g it automatically.

http://websvn.kde.org/?view=3Drevision&revision=3D1282282








- Lamarque






On August 20th, 2011, 8:59 a.m., Pali Roh=C3=A1r wrote:









 

  


Review request for Kopete.


By Pali Roh=C3=A1r.




Updated Aug. 20, 2011, 8:59 a.m.








Descripti=
on 

 

 

  
   
This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update s=
upported protocol lists and update information box about unsupported protoc=
ol.

  		
 






Testing <=
/h1>


 

  
   
Patch working for me fine.

  		
 








Diffs=
 


    

 
  • trunk/extragear/network/kopete-cryptography/CMakeLists.txt (1248234)
    • 

 
  • trunk/extragear/network/kopete-cryptography/cryptographyplugin.h (1248234)
    • 

 
  • trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp (1248234)
    • 





View Diff





  		
 











  

 



--===============2055917289656735103==--

--===============6974571045196255717==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

--===============6974571045196255717==--