[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Do not ignore action moving contact to group from Gui if some accounts are offli
From: Pali_Rohár <pali.rohar () gmail ! com>
Date: 2012-02-25 18:40:14
Message-ID: 20120225184014.23486.82273 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote:
> > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, line \
> > 442 <http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line442>
> >
> > msg could be const.
fixed
> On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote:
> > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, line \
> > 443 <http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line443>
> >
> > The i18n call should have some context (actually, using i18nc might be better \
> > here).
>
> Pali Rohár wrote:
> What do you mean with "should have same context"?
>
> Raphael Kubo da Costa wrote:
> I mean "add context to the translator". If a translator comes across "Move" when \
> translating Kopete, he is unable to know in what context it was used, if this is a \
> verb or a noun, what is supposed to be moved etc.
> So in this case you use i18nc() instead of i18n() to tell the translator in what \
> part of the code this is being used (if this is a menu item, a dialog, a window \
> title etc) and how. You can also use some semantic markup to make it even easier \
> for the translators to figure out the proper words to use (see \
> http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics).
I renamed "Move" to "Move contact".
- Pali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6773/#review10369
-----------------------------------------------------------
On Feb. 25, 2012, 6:40 p.m., Pali Rohár wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6773/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2012, 6:40 p.m.)
>
>
> Review request for Kopete.
>
>
> Description
> -------
>
> Instead ignoring action move contact to group (and do not show any \
> warning/message), this patch ask user warning message if he really want to move \
> contact to group. This can be usefull if some accounts are offline and user want to \
> move metacontact (with contact belong to offline account) into other group.
>
> This addresses bug 202862.
> https://bugs.kde.org/show_bug.cgi?id=202862
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp 1282223
>
> Diff: http://svn.reviewboard.kde.org/r/6773/diff/
>
>
> Testing
> -------
>
> Tested and working fine.
>
>
> Thanks,
>
> Pali Rohár
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6773/">http://svn.reviewboard.kde.org/r/6773/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 23rd, 2011, 1:16 a.m., <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line442" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KopeteContactListView::moveToGroup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">442</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n">QString</span> <span class="n">msg</span> <span \
class="o">=</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Account %1 is offline. Do you really want to move this \
metacontact?"</span><span class="p">,</span> <span class="n">c</span><span \
class="o">-></span><span class="n">account</span><span class="p">()</span><span \
class="o">-></span><span class="n">accountLabel</span><span class="p">()</span> \
<span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">msg could be \
const.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed</pre> \
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 23rd, 2011, 1:16 a.m., <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line443" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KopeteContactListView::moveToGroup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">443</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="k">if</span> <span class="p">(</span> <span \
class="n">KMessageBox</span><span class="o">::</span><span \
class="n">warningYesNo</span><span class="p">(</span> <span \
class="k">this</span><span class="p">,</span> <span class="n">msg</span><span \
class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span \
class="s">"Move"</span> <span class="p">),</span> <span \
class="n">KStandardGuiItem</span><span class="o">::</span><span \
class="n">yes</span><span class="p">(),</span> <span \
class="n">KStandardGuiItem</span><span class="o">::</span><span \
class="n">no</span><span class="p">(),</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The i18n call should \
have some context (actually, using i18nc might be better here).</pre> </blockquote>
<p>On August 24th, 2011, 8:23 a.m., <b>Pali Rohár</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you mean with \
"should have same context"?</pre> </blockquote>
<p>On August 26th, 2011, 2:15 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I mean "add context \
to the translator". If a translator comes across "Move" when \
translating Kopete, he is unable to know in what context it was used, if this is a \
verb or a noun, what is supposed to be moved etc.
So in this case you use i18nc() instead of i18n() to tell the translator in what part \
of the code this is being used (if this is a menu item, a dialog, a window title etc) \
and how. You can also use some semantic markup to make it even easier for the \
translators to figure out the proper words to use (see \
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics).</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I renamed \
"Move" to "Move contact".</pre> <br />
<p>- Pali</p>
<br />
<p>On February 25th, 2012, 6:40 p.m., Pali Rohár wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2012, 6:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead ignoring action move contact to group (and do not show any \
warning/message), this patch ask user warning message if he really want to move \
contact to group. This can be usefull if some accounts are offline and user want to \
move metacontact (with contact belong to offline account) into other group.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and working fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=202862">202862</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <span \
style="color: grey">(1282223)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic