From kopete-devel Sat Feb 25 18:40:14 2012 From: =?utf-8?q?Pali_Roh=C3=A1r?= Date: Sat, 25 Feb 2012 18:40:14 +0000 To: kopete-devel Subject: Re: Review Request: Do not ignore action moving contact to group from Gui if some accounts are offli Message-Id: <20120225184014.23486.82273 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kopete-devel&m=133019525830786 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3006053039247777511==" --===============3006053039247777511== Content-Type: multipart/alternative; boundary="===============4279113865732740032==" --===============4279113865732740032== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.c= pp, line 442 > > > > > > msg could be const. fixed > On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.c= pp, line 443 > > > > > > The i18n call should have some context (actually, using i18nc might= be better here). > = > Pali Roh=C3=A1r wrote: > What do you mean with "should have same context"? > = > Raphael Kubo da Costa wrote: > I mean "add context to the translator". If a translator comes across = "Move" when translating Kopete, he is unable to know in what context it was= used, if this is a verb or a noun, what is supposed to be moved etc. > = > So in this case you use i18nc() instead of i18n() to tell the transla= tor in what part of the code this is being used (if this is a menu item, a = dialog, a window title etc) and how. You can also use some semantic markup = to make it even easier for the translators to figure out the proper words t= o use (see http://techbase.kde.org/Development/Tutorials/Localization/i18n_= Semantics). I renamed "Move" to "Move contact". - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6773/#review10369 ----------------------------------------------------------- On Feb. 25, 2012, 6:40 p.m., Pali Roh=C3=A1r wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6773/ > ----------------------------------------------------------- > = > (Updated Feb. 25, 2012, 6:40 p.m.) > = > = > Review request for Kopete. > = > = > Description > ------- > = > Instead ignoring action move contact to group (and do not show any warnin= g/message), this patch ask user warning message if he really want to move c= ontact to group. This can be usefull if some accounts are offline and user = want to move metacontact (with contact belong to offline account) into othe= r group. > = > = > This addresses bug 202862. > https://bugs.kde.org/show_bug.cgi?id=3D202862 > = > = > Diffs > ----- > = > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.c= pp 1282223 = > = > Diff: http://svn.reviewboard.kde.org/r/6773/diff/ > = > = > Testing > ------- > = > Tested and working fine. > = > = > Thanks, > = > Pali Roh=C3=A1r > = > --===============4279113865732740032== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6773/

On August 23rd, 2011, 1:16 a.m., Raphael Ku= bo da Costa wrote:

= = =
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactl= istview.cpp (Diff revision 1) 
void KopeteContactListView::moveToGroup()
 

    442
    
	=
			QString msg =3D i18n( "Account %1 is offline. Do you really want to move this metacontac=
t?", c->account()=
->accountLabel<=
span class=3D"p">() );

  


 




  
msg could=
 be const.

 









fixed






 
On August 23rd, 2011, 1:16 a.m., Raphael Ku=
bo da Costa wrote:

 

  =









 =

 =




 

 
  

   
    /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactl=
istview.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
void KopeteContactListView::moveToGroup()


  

 

  

    
    

    443
    
	=
			if ( KMessageBox::warningYesNo( this, msg, =
i18n( "Move" ), KStandardGuiItem<=
span class=3D"o">::yes(),=
 KStandardGuiItem::no(),

  


 




  
The i18n =
call should have some context (actually, using i18nc might be better here).=


 




 
On August 24th, 2011, 8:23 a.m., Pali Roh=C3=A1r wrote:

 

  
What do y=
ou mean with "should have same context"?

 






 
On August 26th, 2011, 2:15 p.m., Raphael Kubo da Costa wrote:

 

  
I mean &q=
uot;add context to the translator". If a translator comes across "=
;Move" when translating Kopete, he is unable to know in what context i=
t was used, if this is a verb or a noun, what is supposed to be moved etc.

So in this case you use i18nc() instead of i18n() to tell the translator in=
 what part of the code this is being used (if this is a menu item, a dialog=
, a window title etc) and how. You can also use some semantic markup to mak=
e it even easier for the translators to figure out the proper words to use =
(see http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semant=
ics).

 











I renamed "Move" to "Move contact".








- Pali






On February 25th, 2012, 6:40 p.m., Pali Roh=C3=A1r wrote:









 

  


Review request for Kopete.


By Pali Roh=C3=A1r.




Updated Feb. 25, 2012, 6:40 p.m.








Descripti=
on 

 

 

  
   
Instead ignoring action move contact to group (and do not sh=
ow any warning/message), this patch ask user warning message if he really w=
ant to move contact to group. This can be usefull if some accounts are offl=
ine and user want to move metacontact (with contact belong to offline accou=
nt) into other group.

  		
 






Testing <=
/h1>


 

  
   
Tested and working fine.

  		
 








 Bugs: 


 202862







Diffs=
 


    

 
  • /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.=
cpp (1282223)
    • 





View Diff





  		
 











  

 



--===============4279113865732740032==--

--===============3006053039247777511==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

--===============3006053039247777511==--