On August 23rd, 2011, 1:16 a.m., Raphael Kubo da Costa wrote:

/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp (Diff revision 1)
void KopeteContactListView::moveToGroup()
		442	QString msg = i18n( "Account %1 is offline. Do you really want to move this metacontact?", c->account()->accountLabel() );

msg could be const.

fixed

On August 23rd, 2011, 1:16 a.m., Raphael Kubo da Costa wrote:

/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp (Diff revision 1)
void KopeteContactListView::moveToGroup()
		443	if ( KMessageBox::warningYesNo( this, msg, i18n( "Move" ), KStandardGuiItem::yes(), KStandardGuiItem::no(),

The i18n call should have some context (actually, using i18nc might be better here).

On August 24th, 2011, 8:23 a.m., Pali Rohár wrote:

What do you mean with "should have same context"?

On August 26th, 2011, 2:15 p.m., Raphael Kubo da Costa wrote:

I mean "add context to the translator". If a translator comes across "Move" when translating Kopete, he is unable to know in what context it was used, if this is a verb or a noun, what is supposed to be moved etc.

So in this case you use i18nc() instead of i18n() to tell the translator in what part of the code this is being used (if this is a menu item, a dialog, a window title etc) and how. You can also use some semantic markup to make it even easier for the translators to figure out the proper words to use (see http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics).

I renamed "Move" to "Move contact".

- Pali

On February 25th, 2012, 6:40 p.m., Pali Rohár wrote:

Instead ignoring action move contact to group (and do not show any warning/message), this patch ask user warning message if he really want to move contact to group. This can be usefull if some accounts are offline and user want to move metacontact (with contact belong to offline account) into other group.

Tested and working fine.