[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] On review board Was: Review Request: GaduGadu
From:       Matt Rogers <mattr () kde ! org>
Date:       2009-09-14 21:54:37
Message-ID: 200909141654.37613.mattr () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 14 September 2009 16:00:13 Aleix Pol wrote:
> Review board is great but I wonder if we should center so much on the
> whitespaces on the review. I mean, yes they're ugly and bad, but when
> someone sends his patch, he wants people to be focused on the actual
>  work...
> 
> :/ no?
> 

I won't commit a patch that has whitespace errors, so yes, for the first 
review, I'm going to make sure I knock out the low hanging fruit. This is my 
approach to patch review. Sorry you don't like it</sarcasm>

In this case, there's nothing else wrong with the patch other than the 
whitespace, so once I look over it again to make sure it still looks ok, then 
I'll commit it. 

Also, please don't top post on mailing lists.
--
Matt

> On Mon, Sep 14, 2009 at 1:01 PM, Jakub Grandys <pennguin@gmail.com> 
wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1604/
> > -----------------------------------------------------------
> >
> > (Updated 2009-09-14 20:01:56.874976)
> >
> >
> > Review request for Kopete.
> >
> >
> > Changes
> > -------
> >
> > Whitespaces fixed and small bug - default value for export on change 
and
> > ignore anons were swaped.
> >
> >
> > Summary
> > -------
> >
> > Complete fix for importing and exporting contacts list. All known to me
> > related bugs are fixed:
> > - improper generation of exported list
> > - bad handling of messed up lists
> > - ability to add contact with empty, nonnumerical or UID=0
> > - with empty contacts list you wouldn't receive ANY message or contacts
> > list from server
> >
> > New features:
> > - delete contacts list
> > - manual import from account's action menu
> > - config options for both import on login in and export contacts on any
> > change to contacts list to server (currently not configurable, default is
> > same as now)
> > - revoked action menu (see screenshots)
> >
> >
> > This addresses bugs 184696, 204282 and 204285.
> >    https://bugs.kde.org/show_bug.cgi?id=184696
> >    https://bugs.kde.org/show_bug.cgi?id=204282
> >    https://bugs.kde.org/show_bug.cgi?id=204285
> >
> >
> > Diffs (updated)
> > -----
> >
> >  /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp 
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp 
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui
> > 1023241
> >
> > Diff: http://reviewboard.kde.org/r/1604/diff
> >
> >
> > Testing
> > -------
> >
> > Works for me ;)
> >
> >
> > Screenshots
> > -----------
> >
> > New ActionMenu
> >  http://reviewboard.kde.org/r/1604/s/202/
> > Old ActionMenu
> >  http://reviewboard.kde.org/r/1604/s/204/
> >
> >
> > Thanks,
> >
> > Jakub
> >
> > _______________________________________________
> > kopete-devel mailing list
> > kopete-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kopete-devel
> 

-- 
Matt

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]