From kopete-devel  Mon Sep 14 21:54:37 2009
From: Matt Rogers <mattr () kde ! org>
Date: Mon, 14 Sep 2009 21:54:37 +0000
To: kopete-devel
Subject: Re: [kopete-devel] On review board Was: Review Request: GaduGadu
Message-Id: <200909141654.37613.mattr () kde ! org>
X-MARC-Message: https://marc.info/?l=kopete-devel&m=125315161603605
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0631063098=="

--===============0631063098==
Content-Type: multipart/signed;
  boundary="nextPart4657682.ZmSVAl194H";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart4657682.ZmSVAl194H
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable

On Monday 14 September 2009 16:00:13 Aleix Pol wrote:
> Review board is great but I wonder if we should center so much on the
> whitespaces on the review. I mean, yes they're ugly and bad, but when
> someone sends his patch, he wants people to be focused on the actual
>  work...
>=20
> :/ no?
>=20

I won't commit a patch that has whitespace errors, so yes, for the first=20
review, I'm going to make sure I knock out the low hanging fruit. This is m=
y=20
approach to patch review. Sorry you don't like it</sarcasm>

In this case, there's nothing else wrong with the patch other than the=20
whitespace, so once I look over it again to make sure it still looks ok, th=
en=20
I'll commit it.=20

Also, please don't top post on mailing lists.
=2D-
Matt

> On Mon, Sep 14, 2009 at 1:01 PM, Jakub Grandys <pennguin@gmail.com>=20
wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1604/
> > -----------------------------------------------------------
> >
> > (Updated 2009-09-14 20:01:56.874976)
> >
> >
> > Review request for Kopete.
> >
> >
> > Changes
> > -------
> >
> > Whitespaces fixed and small bug - default value for export on change=20
and
> > ignore anons were swaped.
> >
> >
> > Summary
> > -------
> >
> > Complete fix for importing and exporting contacts list. All known to me
> > related bugs are fixed:
> > - improper generation of exported list
> > - bad handling of messed up lists
> > - ability to add contact with empty, nonnumerical or UID=3D0
> > - with empty contacts list you wouldn't receive ANY message or contacts
> > list from server
> >
> > New features:
> > - delete contacts list
> > - manual import from account's action menu
> > - config options for both import on login in and export contacts on any
> > change to contacts list to server (currently not configurable, default =
is
> > same as now)
> > - revoked action menu (see screenshots)
> >
> >
> > This addresses bugs 184696, 204282 and 204285.
> >    https://bugs.kde.org/show_bug.cgi?id=3D184696
> >    https://bugs.kde.org/show_bug.cgi?id=3D204282
> >    https://bugs.kde.org/show_bug.cgi?id=3D204285
> >
> >
> > Diffs (updated)
> > -----
> >
> >  /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp=20
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp=20
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp=20
1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241
> >  /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui
> > 1023241
> >
> > Diff: http://reviewboard.kde.org/r/1604/diff
> >
> >
> > Testing
> > -------
> >
> > Works for me ;)
> >
> >
> > Screenshots
> > -----------
> >
> > New ActionMenu
> >  http://reviewboard.kde.org/r/1604/s/202/
> > Old ActionMenu
> >  http://reviewboard.kde.org/r/1604/s/204/
> >
> >
> > Thanks,
> >
> > Jakub
> >
> > _______________________________________________
> > kopete-devel mailing list
> > kopete-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kopete-devel
>=20

=2D-=20
Matt

--nextPart4657682.ZmSVAl194H
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)

iEYEABECAAYFAkquu50ACgkQA6Vv5rghv0dDFgCZAbokcH4YhbqSU5b7SiZdXsVE
6joAnjodMKptIdUfhWO2cuEX4rpZmppt
=Sv14
-----END PGP SIGNATURE-----

--nextPart4657682.ZmSVAl194H--

--===============0631063098==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

--===============0631063098==--