'[kopete-devel] On review board Was: Review Request: GaduGadu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] On review board Was: Review Request: GaduGadu
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2009-09-14 21:00:13
Message-ID: 757d9a550909141400n72144a07n5d171890cdac7c69 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Review board is great but I wonder if we should center so much on the
whitespaces on the review. I mean, yes they're ugly and bad, but when
someone sends his patch, he wants people to be focused on the actual work...

:/ no?

On Mon, Sep 14, 2009 at 1:01 PM, Jakub Grandys <pennguin@gmail.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1604/
> -----------------------------------------------------------
>
> (Updated 2009-09-14 20:01:56.874976)
>
>
> Review request for Kopete.
>
>
> Changes
> -------
>
> Whitespaces fixed and small bug - default value for export on change and
> ignore anons were swaped.
>
>
> Summary
> -------
>
> Complete fix for importing and exporting contacts list. All known to me
> related bugs are fixed:
> - improper generation of exported list
> - bad handling of messed up lists
> - ability to add contact with empty, nonnumerical or UID=0
> - with empty contacts list you wouldn't receive ANY message or contacts
> list from server
>
> New features:
> - delete contacts list
> - manual import from account's action menu
> - config options for both import on login in and export contacts on any
> change to contacts list to server (currently not configurable, default is
> same as now)
> - revoked action menu (see screenshots)
>
>
> This addresses bugs 184696, 204282 and 204285.
>    https://bugs.kde.org/show_bug.cgi?id=184696
>    https://bugs.kde.org/show_bug.cgi?id=204282
>    https://bugs.kde.org/show_bug.cgi?id=204285
>
>
> Diffs (updated)
> -----
>
>  /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241
>  /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui
> 1023241
>
> Diff: http://reviewboard.kde.org/r/1604/diff
>
>
> Testing
> -------
>
> Works for me ;)
>
>
> Screenshots
> -----------
>
> New ActionMenu
>  http://reviewboard.kde.org/r/1604/s/202/
> Old ActionMenu
>  http://reviewboard.kde.org/r/1604/s/204/
>
>
> Thanks,
>
> Jakub
>
> _______________________________________________
> kopete-devel mailing list
> kopete-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kopete-devel
>

[Attachment #5 (text/html)]

Review board is great but I wonder if we should center so much on the whitespaces on \
the review. I mean, yes they&#39;re ugly and bad, but when someone sends his patch, \
he wants people to be focused on the actual work...<br> <br>:/ no?<br><br><div \
class="gmail_quote">On Mon, Sep 14, 2009 at 1:01 PM, Jakub Grandys <span \
dir="ltr">&lt;<a href="mailto:pennguin@gmail.com">pennguin@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/1604/" \
                target="_blank">http://reviewboard.kde.org/r/1604/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-09-14 20:01:56.874976)<br>
<br>
<br>
Review request for Kopete.<br>
<br>
<br>
Changes<br>
-------<br>
<br>
Whitespaces fixed and small bug - default value for export on change and ignore anons \
were swaped.<br> <div class="im"><br>
<br>
Summary<br>
-------<br>
<br>
Complete fix for importing and exporting contacts list. All known to me related bugs \
                are fixed:<br>
- improper generation of exported list<br>
- bad handling of messed up lists<br>
- ability to add contact with empty, nonnumerical or UID=0<br>
- with empty contacts list you wouldn&#39;t receive ANY message or contacts list from \
server<br> <br>
New features:<br>
- delete contacts list<br>
- manual import from account&#39;s action menu<br>
- config options for both import on login in and export contacts on any change to \
                contacts list to server (currently not configurable, default is same \
                as now)<br>
- revoked action menu (see screenshots)<br>
<br>
<br>
This addresses bugs 184696, 204282 and 204285.<br>
      <a href="https://bugs.kde.org/show_bug.cgi?id=184696" \
                target="_blank">https://bugs.kde.org/show_bug.cgi?id=184696</a><br>
      <a href="https://bugs.kde.org/show_bug.cgi?id=204282" \
                target="_blank">https://bugs.kde.org/show_bug.cgi?id=204282</a><br>
      <a href="https://bugs.kde.org/show_bug.cgi?id=204285" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=204285</a><br> <br>
<br>
</div>Diffs (updated)<br>
<div><div></div><div class="h5">-----<br>
<br>
   /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241<br>
   /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui 1023241<br>
<br>
Diff: <a href="http://reviewboard.kde.org/r/1604/diff" \
target="_blank">http://reviewboard.kde.org/r/1604/diff</a><br> <br>
<br>
Testing<br>
-------<br>
<br>
Works for me ;)<br>
<br>
<br>
Screenshots<br>
-----------<br>
<br>
New ActionMenu<br>
   <a href="http://reviewboard.kde.org/r/1604/s/202/" \
target="_blank">http://reviewboard.kde.org/r/1604/s/202/</a><br> Old ActionMenu<br>
   <a href="http://reviewboard.kde.org/r/1604/s/204/" \
target="_blank">http://reviewboard.kde.org/r/1604/s/204/</a><br> <br>
<br>
Thanks,<br>
<br>
Jakub<br>
<br>
_______________________________________________<br>
kopete-devel mailing list<br>
<a href="mailto:kopete-devel@kde.org">kopete-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kopete-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kopete-devel</a><br> \
</div></div></blockquote></div><br>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 