[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: GaduGadu import/export contacts
From:       "Jakub Grandys" <pennguin () gmail ! com>
Date:       2009-09-14 20:01:57
Message-ID: 20090914200157.23739.49024 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1604/
-----------------------------------------------------------

(Updated 2009-09-14 20:01:56.874976)


Review request for Kopete.


Changes
-------

Whitespaces fixed and small bug - default value for export on change and ignore anons \
were swaped.


Summary
-------

Complete fix for importing and exporting contacts list. All known to me related bugs \
                are fixed:
- improper generation of exported list
- bad handling of messed up lists
- ability to add contact with empty, nonnumerical or UID=0
- with empty contacts list you wouldn't receive ANY message or contacts list from \
server

New features:
- delete contacts list
- manual import from account's action menu
- config options for both import on login in and export contacts on any change to \
                contacts list to server (currently not configurable, default is same \
                as now)
- revoked action menu (see screenshots)


This addresses bugs 184696, 204282 and 204285.
    https://bugs.kde.org/show_bug.cgi?id=184696
    https://bugs.kde.org/show_bug.cgi?id=204282
    https://bugs.kde.org/show_bug.cgi?id=204285


Diffs (updated)
-----

  /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241 
  /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui 1023241 

Diff: http://reviewboard.kde.org/r/1604/diff


Testing
-------

Works for me ;)


Screenshots
-----------

New ActionMenu
  http://reviewboard.kde.org/r/1604/s/202/
Old ActionMenu
  http://reviewboard.kde.org/r/1604/s/204/


Thanks,

Jakub

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]