[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] History Import extension
From:       Matt Rogers <mattr () kde ! org>
Date:       2009-01-11 4:54:07
Message-ID: 200901102254.11636.mattr () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 22 December 2008 11:07:06 Timo Schlüßler wrote:
> attached is a version where i changed the things you mentioned in irc ...
>
> regards
>
> Olivier Goffart wrote:
> > Le mercredi 3 décembre 2008, Timo Schlüßler a écrit :
> >> Hello,
> >>
> >> attached is a patch and the two files which add the ability to import
> >> logs from pidgin to kopete. The source-code files belong to
> >> kdenetwork/kopete/plugins/history.
> >> I changed HistoryLogger slightly so that appendMessage() uses the
> >> timestamp from the message that is to be imported  but not
> >> QDate::currentDate().
> >>
> >> I don't know what happens if you want to import multiuser chatlogs
> >> because i haven't got any ... i would be glad if you can check that.
> >> For me it works just fine, but the logs from pidgin are very unsteady.
> >> anyway i hope it works for all pidgin logs.
> >
> > Hi,
> >
> > sorry for answering so late.
> >
> > You shouldn't change the reference date in the getDocument() function.
> >
> > You should understand that by definition, the 'int month' passed to the
> > getDocument function is the difference between the _current_ month and
> > the month of the document you ask.
> >
> > So you should not change the reference.
> >
> > What you should do instead is, in appendMessage, call the overloaded
> > getDocument, that take a QDate instead.
> > BUT then move the cache from the function that take an integer to this
> > one.
> >
> >

I committed your patch! Thanks for your contribution!
-- 
Matt

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]