From kopete-devel  Sun Jan 11 04:54:07 2009
From: Matt Rogers <mattr () kde ! org>
Date: Sun, 11 Jan 2009 04:54:07 +0000
To: kopete-devel
Subject: Re: [kopete-devel] History Import extension
Message-Id: <200901102254.11636.mattr () kde ! org>
X-MARC-Message: https://marc.info/?l=kopete-devel&m=123164968204856
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1433882695=="

--===============1433882695==
Content-type: multipart/signed; boundary=nextPart1267667.UBGgUNon36;
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-transfer-encoding: 7bit

--nextPart1267667.UBGgUNon36
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 22 December 2008 11:07:06 Timo Schl=FC=DFler wrote:
> attached is a version where i changed the things you mentioned in irc ...
>
> regards
>
> Olivier Goffart wrote:
> > Le mercredi 3 d=E9cembre 2008, Timo Schl=FC=DFler a =E9crit :
> >> Hello,
> >>
> >> attached is a patch and the two files which add the ability to import
> >> logs from pidgin to kopete. The source-code files belong to
> >> kdenetwork/kopete/plugins/history.
> >> I changed HistoryLogger slightly so that appendMessage() uses the
> >> timestamp from the message that is to be imported  but not
> >> QDate::currentDate().
> >>
> >> I don't know what happens if you want to import multiuser chatlogs
> >> because i haven't got any ... i would be glad if you can check that.
> >> For me it works just fine, but the logs from pidgin are very unsteady.
> >> anyway i hope it works for all pidgin logs.
> >
> > Hi,
> >
> > sorry for answering so late.
> >
> > You shouldn't change the reference date in the getDocument() function.
> >
> > You should understand that by definition, the 'int month' passed to the
> > getDocument function is the difference between the _current_ month and
> > the month of the document you ask.
> >
> > So you should not change the reference.
> >
> > What you should do instead is, in appendMessage, call the overloaded
> > getDocument, that take a QDate instead.
> > BUT then move the cache from the function that take an integer to this
> > one.
> >
> >

I committed your patch! Thanks for your contribution!
=2D-=20
Matt

--nextPart1267667.UBGgUNon36
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAklpe3MACgkQA6Vv5rghv0fIQQCglezNAQTvm1zTiA1JFOfYkBDK
VRgAn0ijPXWXzqox7q3Ge1ricUrM4UoE
=J1ng
-----END PGP SIGNATURE-----

--nextPart1267667.UBGgUNon36--

--===============1433882695==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

--===============1433882695==--