'Re: [kopete-devel] History Import extension'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] History Import extension
From:       Timo_Schlüßler <timo () schluessler ! org>
Date:       2009-01-11 19:33:43
Message-ID: 496A4997.8000305 () schluessler ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Thank you for committing the patch :)

regards,
Timo

Matt Rogers wrote:
> On Monday 22 December 2008 11:07:06 Timo Schlüßler wrote:
>   
>> attached is a version where i changed the things you mentioned in irc ...
>>
>> regards
>>
>> Olivier Goffart wrote:
>>     
>>> Le mercredi 3 décembre 2008, Timo Schlüßler a écrit :
>>>       
>>>> Hello,
>>>>
>>>> attached is a patch and the two files which add the ability to import
>>>> logs from pidgin to kopete. The source-code files belong to
>>>> kdenetwork/kopete/plugins/history.
>>>> I changed HistoryLogger slightly so that appendMessage() uses the
>>>> timestamp from the message that is to be imported  but not
>>>> QDate::currentDate().
>>>>
>>>> I don't know what happens if you want to import multiuser chatlogs
>>>> because i haven't got any ... i would be glad if you can check that.
>>>> For me it works just fine, but the logs from pidgin are very unsteady.
>>>> anyway i hope it works for all pidgin logs.
>>>>         
>>> Hi,
>>>
>>> sorry for answering so late.
>>>
>>> You shouldn't change the reference date in the getDocument() function.
>>>
>>> You should understand that by definition, the 'int month' passed to the
>>> getDocument function is the difference between the _current_ month and
>>> the month of the document you ask.
>>>
>>> So you should not change the reference.
>>>
>>> What you should do instead is, in appendMessage, call the overloaded
>>> getDocument, that take a QDate instead.
>>> BUT then move the cache from the function that take an integer to this
>>> one.
>>>
>>>
>>>       
>
> I committed your patch! Thanks for your contribution!
>   

[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Thank you for committing the patch :)<br>
<br>
regards,<br>
Timo<br>
<br>
Matt Rogers wrote:
<blockquote cite="mid:200901102254.11636.mattr@kde.org" type="cite">
  <pre wrap="">On Monday 22 December 2008 11:07:06 Timo Schl&uuml;&szlig;ler wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap="">attached is a version where i changed the things you mentioned in irc ...

regards

Olivier Goffart wrote:
    </pre>
    <blockquote type="cite">
      <pre wrap="">Le mercredi 3 d&eacute;cembre 2008, Timo Schl&uuml;&szlig;ler a &eacute;crit :
      </pre>
      <blockquote type="cite">
        <pre wrap="">Hello,

attached is a patch and the two files which add the ability to import
logs from pidgin to kopete. The source-code files belong to
kdenetwork/kopete/plugins/history.
I changed HistoryLogger slightly so that appendMessage() uses the
timestamp from the message that is to be imported  but not
QDate::currentDate().

I don't know what happens if you want to import multiuser chatlogs
because i haven't got any ... i would be glad if you can check that.
For me it works just fine, but the logs from pidgin are very unsteady.
anyway i hope it works for all pidgin logs.
        </pre>
      </blockquote>
      <pre wrap="">Hi,

sorry for answering so late.

You shouldn't change the reference date in the getDocument() function.

You should understand that by definition, the 'int month' passed to the
getDocument function is the difference between the _current_ month and
the month of the document you ask.

So you should not change the reference.

What you should do instead is, in appendMessage, call the overloaded
getDocument, that take a QDate instead.
BUT then move the cache from the function that take an integer to this
one.

      </pre>
    </blockquote>
  </blockquote>
  <pre wrap=""><!---->
I committed your patch! Thanks for your contribution!
  </pre>
</blockquote>
</body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 