[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] Autoaway plugin
From:       Ladislav Strojil <Ladislav.Strojil () seznam ! cz>
Date:       2002-05-05 7:43:27
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 05 May 2002 01:01, Martijn Klingens wrote:
> On Saturday 04 May 2002 15:22, Ladislav Strojil wrote:
> > I am not getting your point. You would like the status() method to return
> > current status? Again, since there is not uniform representation, this
> > does not make currently much sense.
>
> No, my point is that it should be *made* a uniform representation, because
> your approach has very error-prone side effects. ;-) What if, for example,
> you call storeStatus(), setAway() and again storeStatus() ? 

Hi,

yes, I am aware of this. In this case Away status would be stored/restored.
But even if I implement uniform way of representing status and then call 
getStatuses, setAwayAll, getStatuses, I'm boned. :-))

> Do you avoid unnecessary code
> duplication by reusing the status setting code that is also currently in
> e.g. setAway() ? 

Ehm, storing status is one line and restoring is three. 
Speaking of the ICQ plugin, setting status is just two lines of code, its 
engine->setStatus + setting the appropriate icon. There is no duplication. 

> I know that's much more work, but also much more generally
> useful for Kopete.

Yes, I agree with that. 

> If there is something, you should ask Ryan. I thought he was doing it, so I
> never spent time on it myself. If Ryan didn't do this (yet?) it has to be
> created from scratch, unfortunately.

OK, I am willing to do that, I'll ask Ryan about it and if there is nothing I 
will start from scratch. I may need your assistence however, I am new to 
kopete development (well, to be precise I started looking at the code 
yesterday).

Cheers,
Lada

- -- 
    ~       Ladislav Strojil, MFF UK
  ' v '               
 //   \\              
/(     )\    Powered by Penguin.
  ^ ' ^
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE81OKfTnMZPFqq4nwRAoAjAJ4mebHRVNg/xJdRG9M1YyxUnsvwxACgrOR/
o7YnjdbGyo7FbKAL3hs/Zy0=
=IjPB
-----END PGP SIGNATURE-----

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]