From kopete-devel Sun May 05 07:43:27 2002 From: Ladislav Strojil Date: Sun, 05 May 2002 07:43:27 +0000 To: kopete-devel Subject: Re: [Kopete-devel] Autoaway plugin X-MARC-Message: https://marc.info/?l=kopete-devel&m=102058490932379 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sunday 05 May 2002 01:01, Martijn Klingens wrote: > On Saturday 04 May 2002 15:22, Ladislav Strojil wrote: > > I am not getting your point. You would like the status() method to re= turn > > current status? Again, since there is not uniform representation, thi= s > > does not make currently much sense. > > No, my point is that it should be *made* a uniform representation, beca= use > your approach has very error-prone side effects. ;-) What if, for examp= le, > you call storeStatus(), setAway() and again storeStatus() ?=20 Hi, yes, I am aware of this. In this case Away status would be stored/restore= d. But even if I implement uniform way of representing status and then call=20 getStatuses, setAwayAll, getStatuses, I'm boned. :-)) > Do you avoid unnecessary code > duplication by reusing the status setting code that is also currently i= n > e.g. setAway() ?=20 Ehm, storing status is one line and restoring is three.=20 Speaking of the ICQ plugin, setting status is just two lines of code, its= =20 engine->setStatus + setting the appropriate icon. There is no duplication= =2E=20 > I know that's much more work, but also much more generally > useful for Kopete. Yes, I agree with that.=20 > If there is something, you should ask Ryan. I thought he was doing it, = so I > never spent time on it myself. If Ryan didn't do this (yet?) it has to = be > created from scratch, unfortunately. OK, I am willing to do that, I'll ask Ryan about it and if there is nothi= ng I=20 will start from scratch. I may need your assistence however, I am new to=20 kopete development (well, to be precise I started looking at the code=20 yesterday). Cheers, Lada - --=20 ~ Ladislav Strojil, MFF UK ' v ' =20 // \\ =20 /( )\ Powered by Penguin. ^ ' ^ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE81OKfTnMZPFqq4nwRAoAjAJ4mebHRVNg/xJdRG9M1YyxUnsvwxACgrOR/ o7YnjdbGyo7FbKAL3hs/Zy0=3D =3DIjPB -----END PGP SIGNATURE----- _______________________________________________ Kopete-devel mailing list Kopete-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/kopete-devel