[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Question about the support for the "Scroll Lock" key
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2012-03-04 22:30:36
Message-ID: CAL0LiwTkPK9AkgwvL47ESBvMW--BL67mzZPS7kVkPkrj1T01Pg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Mar 1, 2012 at 10:58 AM, Jekyll Wu <adaptee@gmail.com> wrote:

> This is another KDE3 feature missing in KDE4 konsole. See
> https://bugs.kde.org/show_bug.**cgi?id=172271<https://bugs.kde.org/show_bug.cgi?id=172271>
>
> And here is the commit that removed the broken(?) implementation
>
> commit cee0ce539b23b76eac5a582540b22f**70ba0a2f74
> Author: Robert Knight <robertknight@gmail.com>
> Date:   4 years, 2 months ago
>
>    Remove dead code, including the non-functional scroll lock code. Scroll
> lock support will be re-implemented in the termina
> l display widget post KDE 4.0 if there is a demand for it.
>
> Now the question is should we reimplement it?
>
> I personally does not like to do it, bacause it seems to requires quite
> some code to implement it correctly. Also, a simple google searching of
> "Konsole scroll lock" suggests that feature was annoying to some users when
> it was there.
>
> If the consensus is to not reimplement it again, I think we should clean
> up the left over code related with the "Scroll Lock" key in
> KeyboardTranslator, Vt102Emualtion, and XKB.
>
> Hello,
  None of my keyboards even have a 'Scroll Lock'.  I would agree that
unless it is trivial to implement we need not.  How much old code is there
that could be removed?
   Kurt

[Attachment #5 (text/html)]

<font size="4"><font face="georgia,serif"><br></font></font><br><div \
class="gmail_quote">On Thu, Mar 1, 2012 at 10:58 AM, Jekyll Wu <span dir="ltr">&lt;<a \
href="mailto:adaptee@gmail.com">adaptee@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">This is another KDE3 feature missing in KDE4 konsole. See <a \
href="https://bugs.kde.org/show_bug.cgi?id=172271" \
target="_blank">https://bugs.kde.org/show_bug.<u></u>cgi?id=172271</a><br>


<br>
And here is the commit that removed the broken(?) implementation<br>
<br>
commit cee0ce539b23b76eac5a582540b22f<u></u>70ba0a2f74<br>
Author: Robert Knight &lt;<a href="mailto:robertknight@gmail.com" \
                target="_blank">robertknight@gmail.com</a>&gt;<br>
Date:    4 years, 2 months ago<br>
<br>
      Remove dead code, including the non-functional scroll lock code. Scroll lock \
support will be re-implemented in the termina<br> l display widget post KDE 4.0 if \
there is a demand for it.<br> <br>
Now the question is should we reimplement it?<br>
<br>
I personally does not like to do it, bacause it seems to requires quite some code to \
implement it correctly. Also, a simple google searching of &quot;Konsole scroll \
lock&quot; suggests that feature was annoying to some users when it was there.<br>


<br>
If the consensus is to not reimplement it again, I think we should clean up the left \
over code related with the &quot;Scroll Lock&quot; key in KeyboardTranslator, \
Vt102Emualtion, and XKB.<br> <br></blockquote><div>Hello,</div><div>   None of my \
keyboards even have a &#39;Scroll Lock&#39;.   I would agree that unless it is \
trivial to implement we need not.   How much old code is there that could be \
removed?</div>

<div>     Kurt</div><div>  </div></div>



_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]