--===============5350611969316302204==
Content-Type: multipart/alternative; boundary=00235452ed2c0388ea04ba725da7

--00235452ed2c0388ea04ba725da7
Content-Type: text/plain; charset=UTF-8

On Thu, Mar 1, 2012 at 10:58 AM, Jekyll Wu <adaptee@gmail.com> wrote:

> This is another KDE3 feature missing in KDE4 konsole. See
> https://bugs.kde.org/show_bug.**cgi?id=172271<https://bugs.kde.org/show_bug.cgi?id=172271>
>
> And here is the commit that removed the broken(?) implementation
>
> commit cee0ce539b23b76eac5a582540b22f**70ba0a2f74
> Author: Robert Knight <robertknight@gmail.com>
> Date:   4 years, 2 months ago
>
>    Remove dead code, including the non-functional scroll lock code. Scroll
> lock support will be re-implemented in the termina
> l display widget post KDE 4.0 if there is a demand for it.
>
> Now the question is should we reimplement it?
>
> I personally does not like to do it, bacause it seems to requires quite
> some code to implement it correctly. Also, a simple google searching of
> "Konsole scroll lock" suggests that feature was annoying to some users when
> it was there.
>
> If the consensus is to not reimplement it again, I think we should clean
> up the left over code related with the "Scroll Lock" key in
> KeyboardTranslator, Vt102Emualtion, and XKB.
>
> Hello,
  None of my keyboards even have a 'Scroll Lock'.  I would agree that
unless it is trivial to implement we need not.  How much old code is there
that could be removed?
   Kurt

--00235452ed2c0388ea04ba725da7
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<font size=3D"4"><font face=3D"georgia,serif"><br></font></font><br><div cl=
ass=3D"gmail_quote">On Thu, Mar 1, 2012 at 10:58 AM, Jekyll Wu <span dir=3D=
"ltr">&lt;<a href=3D"mailto:adaptee@gmail.com">adaptee@gmail.com</a>&gt;</s=
pan> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">This is another KDE3 feature missing in KDE4=
 konsole. See <a href=3D"https://bugs.kde.org/show_bug.cgi?id=3D172271" tar=
get=3D"_blank">https://bugs.kde.org/show_bug.<u></u>cgi?id=3D172271</a><br>


<br>
And here is the commit that removed the broken(?) implementation<br>
<br>
commit cee0ce539b23b76eac5a582540b22f<u></u>70ba0a2f74<br>
Author: Robert Knight &lt;<a href=3D"mailto:robertknight@gmail.com" target=
=3D"_blank">robertknight@gmail.com</a>&gt;<br>
Date: =C2=A0 4 years, 2 months ago<br>
<br>
 =C2=A0 =C2=A0Remove dead code, including the non-functional scroll lock co=
de. Scroll lock support will be re-implemented in the termina<br>
l display widget post KDE 4.0 if there is a demand for it.<br>
<br>
Now the question is should we reimplement it?<br>
<br>
I personally does not like to do it, bacause it seems to requires quite som=
e code to implement it correctly. Also, a simple google searching of &quot;=
Konsole scroll lock&quot; suggests that feature was annoying to some users =
when it was there.<br>


<br>
If the consensus is to not reimplement it again, I think we should clean up=
 the left over code related with the &quot;Scroll Lock&quot; key in Keyboar=
dTranslator, Vt102Emualtion, and XKB.<br>
<br></blockquote><div>Hello,</div><div>=C2=A0 None of my keyboards even hav=
e a &#39;Scroll Lock&#39;. =C2=A0I would agree that unless it is trivial to=
 implement we need not. =C2=A0How much old code is there that could be remo=
ved?</div>

<div>=C2=A0 =C2=A0Kurt</div><div>=C2=A0</div></div>

--00235452ed2c0388ea04ba725da7--

--===============5350611969316302204==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

--===============5350611969316302204==--