[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Question about the support for the "Scroll Lock" key
From:       Jekyll Wu <adaptee () gmail ! com>
Date:       2012-03-04 23:01:15
Message-ID: 4F53F43B.3060400 () gmail ! com
[Download RAW message or body]

On 2012年03月05日 06:30, Kurt Hindenburg wrote:
> On Thu, Mar 1, 2012 at 10:58 AM, Jekyll Wu<adaptee@gmail.com>  wrote:
>
>> This is another KDE3 feature missing in KDE4 konsole. See
>> https://bugs.kde.org/show_bug.**cgi?id=172271<https://bugs.kde.org/show_bug.cgi?id=172271>
>>
>> And here is the commit that removed the broken(?) implementation
>>
>> commit cee0ce539b23b76eac5a582540b22f**70ba0a2f74
>> Author: Robert Knight<robertknight@gmail.com>
>> Date:   4 years, 2 months ago
>>
>>     Remove dead code, including the non-functional scroll lock code. Scroll
>> lock support will be re-implemented in the termina
>> l display widget post KDE 4.0 if there is a demand for it.
>>
>> Now the question is should we reimplement it?
>>
>> I personally does not like to do it, bacause it seems to requires quite
>> some code to implement it correctly. Also, a simple google searching of
>> "Konsole scroll lock" suggests that feature was annoying to some users when
>> it was there.
>>
>> If the consensus is to not reimplement it again, I think we should clean
>> up the left over code related with the "Scroll Lock" key in
>> KeyboardTranslator, Vt102Emualtion, and XKB.
>>
>> Hello,
>    None of my keyboards even have a 'Scroll Lock'.  I would agree that
> unless it is trivial to implement we need not.  How much old code is there
> that could be removed?
>     Kurt

About 200 lines. I will submit the diff onto reviewboard.

Jekyll


_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread]