[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (Color tool bar Button)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-06 13:30:42
[Download RAW message or body]

On Friday 06 July 2001 15:42, Toshitaka Fujioka wrote:
> I'm very sorry. I don't it in future. I wait for an answer.

Thanks :)

> I explain.
> Your patch breaked feature of one. I applied a color when I clicked picture
> icon (TK... icon have two icons. picture icon and under arrow icon) formerly.
> I open "KColorDialog" when I clicked picture icon in your patch.

Hmm, I only half understand. This is about clicking on the toolbar button
itself (not opening the submenu), I see. But the fact that it opens a dialog
is a feature - at least in KWord. Since the button always shows the color
of the text under the cursor, clicking on it would do nothing. The point of this
action is to _select_ a color to apply.
You seem to want to apply the color of the button directly. Is this because
KPresenter doesn't show the color of the selected text object in the action ??
(If it does, what good would this patch do ?).
Please elaborate.

If clicking on the button shouldn't always open the dialog for choosing a color,
depending on the application, then the fix is to make this behaviour configurable
(some setBlah() method that changes the behaviour of the action).

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]