[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (Color tool bar Button)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-06 10:02:52
[Download RAW message or body]

On Wednesday 04 July 2001 13:38, Toshitaka Fujioka wrote:
> On Saturday 16 June 2001 21:30, Toshitaka Fujioka wrote:
> > On Friday 15 June 2001 20:43, David Faure wrote:
> > > The problem is that TKSelectColorAction doesn't work when it is plugged
> > > into a menu (try to activate it -> nothing). This needs a fix in
> > > TKSomething. I'd be glad if you had a go at fixing that ;-)
> >
> > OK, I try. But, If it was not able to be fixed, I'm sorry.
> 
> Thanks, David. You're great. ;) 
> 
> But, I remade "TKSelectColorAction" for plugged in menu and
> no plugged in menu (Tool bar).
> I think that I am easy to use this way with tool bar. ;)
> 
> I attached patch (TKselectColorAction, Kivio, KSpread, KPresenter and KWord).
> 
> Please review.

Why did you commit this without waiting for an answer ? Please don't do that.
I was away yesterday and the day before (linux expo in London), so please give
me time to read through all my mail.
Why this hack ? Passing "inMenu" as bool to an action is a VERY AWFUL hack.
An action is supposed to work the same where-ever it's plugged, the creator of 
the action shouldn't have to care about it ! Besides, if the user changes the XML file,
the action will or will not end up in a menu after all. This patch breaks the whole concept.

What does it try to fix ? I don't understand.
I checked that slotActivated() was only called when the activating the menu item.
Did you find a case where this isn't true ? Please explain.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]