[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Bug fix patch for KPresenter (#25032)
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-05-30 10:44:12
[Download RAW message or body]

Hello,

This patch fixes bug number #25032.
Contents of bug report:
------------------------------------------------
While using kpresenter 
(cvs snapshot from ftp.kde.org dated 20010430)
i met a reproduceable crash:

1. Create kpresenter docu
2. Embed diagram into it's first page
3. Select: Insert -> Page -> Before current page -> OK
4. Look at the backtrace
------------------------------------------------

Please review.

-- 
Toshitaka Fujioka
http://www.kde.org                The K Desktop Environment Project
                                                    fujioka@kde.org
http://www.kde.gr.jp               Japan KDE User's Group
                                                    toshitaka@kde.gr.jp

-- We offer the best Desktop Environment to you.  (This is my goal. ;-)) --     


["koffice-kpresenter-%2325032-fix-20010530.diff" (text/plain)]

diff -ur koffice.orig/kpresenter/kpresenter_doc.cc koffice/kpresenter/kpresenter_doc.cc
--- koffice.orig/kpresenter/kpresenter_doc.cc	Tue May 29 18:03:43 2001
+++ koffice/kpresenter/kpresenter_doc.cc	Wed May 30 19:37:06 2001
@@ -3187,7 +3187,11 @@
 
     if ( _insPos == IP_AFTER )
 	_page++;
-    objStartY = getPageRect( _page - 1, 0, 0 ).y() + getPageRect( _page - 1, 0, 0 ).height();
+
+    if ( _page - 1 == -1 )
+        objStartY = -1;
+    else
+        objStartY = getPageRect( _page - 1, 0, 0 ).y() + getPageRect( _page - 1, 0, 0 ).height();
     loadNativeFormat( fileName );
     objStartY = 0;
     _clean = true;

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]