'Re: Review Request: Add parentheses around instatiation of object to avoid ambiguity'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add parentheses around instatiation of object to avoid ambiguity
From:       "Thomas Zander" <zander () kde ! org>
Date:       2012-03-13 19:14:18
Message-ID: 20120313191418.9086.31043 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104262/#review11370
-----------------------------------------------------------

Ship it!

Can't imagine that having any negative side effects, so if it fixes the pro=
blem, then ship it :)

- Thomas Zander

On March 13, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104262/
> -----------------------------------------------------------
> =

> (Updated March 13, 2012, 6:53 p.m.)
> =

> =

> Review request for KOffice.
> =

> =

> Description
> -------
> =

> The clang compiler won't build the unit test without these parentheses cl=
aiming that it doesn't know how to disambiguate a function call.  I'm not s=
ure I understand exactly why, but adding the parens fixes things so that th=
e unit test can build and doesn't have any other negative effect.
> =

> =

> Diffs
> -----
> =

>   kcells/tests/TestLogicFunctions.cpp d49aeda =

> =

> Diff: http://git.reviewboard.kde.org/r/104262/diff/
> =

> =

> Testing
> -------
> =

> Compiled and ran unit tests with both gcc and clang.  All tests still pas=
s (now with both compilers).
> =

> =

> Thanks,
> =

> Robert Mathias Marmorstein
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104262/">http://git.reviewboard.kde.org/r/104262/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can&#39;t imagine that \
having any negative side effects, so if it fixes the problem, then ship it :)</pre>  \
<br />

<p>- Thomas</p>

<br />
<p>On March 13th, 2012, 6:53 p.m., Robert Mathias Marmorstein wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>

<p style="color: grey;"><i>Updated March 13, 2012, 6:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The clang compiler won&#39;t build the unit test without these \
parentheses claiming that it doesn&#39;t know how to disambiguate a function call.  \
I&#39;m not sure I understand exactly why, but adding the parens fixes things so that \
the unit test can build and doesn&#39;t have any other negative effect.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and ran unit tests with both gcc and clang.  All tests still \
pass (now with both compilers).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcells/tests/TestLogicFunctions.cpp <span style="color: \
grey">(d49aeda)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104262/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 