[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Change dynamic_cast in KoPAOdfSaveHelper constructor
From: "Thomas Zander" <zander () kde ! org>
Date: 2012-03-13 19:12:35
Message-ID: 20120313191235.9045.62242 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104263/#review11369
-----------------------------------------------------------
Ship it!
The change looks correct. =
The change made by me some time ago (2nd christmas day 2011) where there us=
ed to be a KoPAPageBase seems to me a likely cause of this bug, apologies f=
or not finding the unit test regression, and thanks for the fix!
- Thomas Zander
On March 13, 2012, 6:59 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104263/
> -----------------------------------------------------------
> =
> (Updated March 13, 2012, 6:59 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> The TestPACopyPastePage unit test was failing with a segmentation fault (=
signal 11). Debugging it in gdb showed that the cause was a null pointer f=
or the "page" variable in a loop through the master pages. Tracing this ba=
ck, I discovered some odd code that seemed to be dynamic_casting a Page* to=
a Page*. I'm not sure that behaviour is even defined in the C++ standard,=
but I'm pretty sure what we really want to do is cast to a MasterPage inst=
ead (and reverse the logic of the if statement). So that's what this patch=
does. =
> =
> =
> Diffs
> -----
> =
> libs/kopageapp/KoPAOdfPageSaveHelper.cpp 1a8f965 =
> =
> Diff: http://git.reviewboard.kde.org/r/104263/diff/
> =
> =
> Testing
> -------
> =
> Code still compiles and runs and master pages work. The TestPACopyPasteP=
age unit test now passes instead of failing and all other unit tests still =
pass (except the two that were failing already -- both related to layout pr=
oblems).
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104263/">http://git.reviewboard.kde.org/r/104263/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change looks \
correct.
The change made by me some time ago (2nd christmas day 2011) where there used to be a \
KoPAPageBase seems to me a likely cause of this bug, apologies for not finding the \
unit test regression, and thanks for the fix!</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 13th, 2012, 6:59 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated March 13, 2012, 6:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The TestPACopyPastePage unit test was failing with a segmentation fault \
(signal 11). Debugging it in gdb showed that the cause was a null pointer for the \
"page" variable in a loop through the master pages. Tracing this back, I \
discovered some odd code that seemed to be dynamic_casting a Page* to a Page*. \
I'm not sure that behaviour is even defined in the C++ standard, but I'm \
pretty sure what we really want to do is cast to a MasterPage instead (and reverse \
the logic of the if statement). So that's what this patch does. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code still compiles and runs and master pages work. The \
TestPACopyPastePage unit test now passes instead of failing and all other unit tests \
still pass (except the two that were failing already -- both related to layout \
problems).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPAOdfPageSaveHelper.cpp <span style="color: \
grey">(1a8f965)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104263/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic