[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: Revert a commit that breaks TestDocumentLayout
From: "Robert Mathias Marmorstein" <robert () narnia ! homeunix ! com>
Date: 2012-03-14 18:09:06
Message-ID: 20120314180906.28857.53111 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/
-----------------------------------------------------------
Review request for KOffice.
Description
-------
This one-line change seems to have broken the kword-frames-TestDocumentLayo=
ut unit test. I don't know whether the behaviour of Qt has changed or if t=
he cursorToX function simply doesn't work as expected, but the test passes =
after reverting this change.
Diffs
-----
kword/part/frames/KWTextDocumentLayout.cpp fc5173d =
Diff: http://git.reviewboard.kde.org/r/104272/diff/
Testing
-------
Everything builds, compiles, runs, and passes the same unit tests (plus one=
more!) if we revert the change. However, it's possible that it's the test=
that's wrong. I don't understand the layout algorithm well enough to know=
for sure.
Thanks,
Robert Mathias Marmorstein
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104272/">http://git.reviewboard.kde.org/r/104272/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This one-line change seems to have broken the \
kword-frames-TestDocumentLayout unit test. I don't know whether the behaviour of \
Qt has changed or if the cursorToX function simply doesn't work as expected, but \
the test passes after reverting this change.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything builds, compiles, runs, and passes the same unit tests (plus \
one more!) if we revert the change. However, it's possible that it's the \
test that's wrong. I don't understand the layout algorithm well enough to \
know for sure.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(fc5173d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104272/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic