'Re: Review Request: KPlato: Account reference is not reset when a task'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KPlato: Account reference is not reset when a task
From:       "Jaroslaw Staniek" <staniek () kde ! org>
Date:       2010-12-20 22:53:21
Message-ID: 20101220225321.2712.84945 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6078/#review9349
-----------------------------------------------------------

branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp
<http://svn.reviewboard.kde.org/r/6078/#comment10351>

    This and the addition from SubtaskAddCmd::SubtaskAddCmd() could be shar=
ed in a separate private function instead of copy/pasting.

- Jaroslaw

On 2010-12-09 18:45:39, Dag Andersen wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6078/
> -----------------------------------------------------------
> =

> (Updated 2010-12-09 18:45:39)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> If the user sets an account reference on a task and then makes it a summa=
ry task, the account is not reset.
> The result is that the cost from the summary tasks subtask may be added t=
wice giving incorrect totals.
> =

> =

> Diffs
> -----
> =

>   branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp 1204885 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6078/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Dag
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6078/">http://svn.reviewboard.kde.org/r/6078/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6078/diff/1/?file=42415#file42415line1017" \
style="color: black; font-weight: bold; text-decoration: \
underline;">branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
NodeIndentCmd::execute()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1017</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="c1">// Also remove accounts</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This and \
the addition from SubtaskAddCmd::SubtaskAddCmd() could be shared in a separate \
private function instead of copy/pasting.</pre> </div>
<br />

<p>- Jaroslaw</p>

<br />
<p>On December 9th, 2010, 6:45 p.m., Dag Andersen wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Dag Andersen.</div>

<p style="color: grey;"><i>Updated 2010-12-09 18:45:39</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the user sets an account reference on a task and then makes it a \
summary task, the account is not reset. The result is that the cost from the summary \
tasks subtask may be added twice giving incorrect totals. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp <span \
style="color: grey">(1204885)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6078/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 