--===============0754015494== Content-Type: multipart/alternative; boundary="===============7193387948166505111==" --===============7193387948166505111== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6078/#review9349 ----------------------------------------------------------- branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp This and the addition from SubtaskAddCmd::SubtaskAddCmd() could be shar= ed in a separate private function instead of copy/pasting. - Jaroslaw On 2010-12-09 18:45:39, Dag Andersen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6078/ > ----------------------------------------------------------- > = > (Updated 2010-12-09 18:45:39) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > If the user sets an account reference on a task and then makes it a summa= ry task, the account is not reset. > The result is that the cost from the summary tasks subtask may be added t= wice giving incorrect totals. > = > = > Diffs > ----- > = > branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp 1204885 = > = > Diff: http://svn.reviewboard.kde.org/r/6078/diff > = > = > Testing > ------- > = > = > Thanks, > = > Dag > = > --===============7193387948166505111== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6078/

= =
branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cp= p (Diff revision 1) 
void NodeIndentCmd::execute()
 

    1017
    
            // Also remove =
accounts

  


 





This and the addition from SubtaskAddCmd::SubtaskAddCmd() could be s=
hared in a separate private function instead of copy/pasting.









- Jaroslaw






On December 9th, 2010, 6:45 p.m., Dag Andersen wrote:









 

  


Review request for KOffice.


By Dag Andersen.




Updated 2010-12-09 18:45:39






Descripti=
on 



 

  
   
If the user sets an account reference on a task and then mak=
es it a summary task, the account is not reset.
The result is that the cost from the summary tasks subtask may be added twi=
ce giving incorrect totals.


  		
 









Diffs=
 


    

 
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kptcommand.cpp (1204885)
    • 





View Diff





  		
 











  

 



--===============7193387948166505111==--

--===============0754015494==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============0754015494==--