[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: kspread: Patch for bug 240235
From: "Sebastian Sauer" <mail () dipe ! org>
Date: 2010-12-03 21:05:31
Message-ID: 20101203210531.12731.1249 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-12-03 19:08:50, Sebastian Sauer wrote:
> > Looks great. koffice/trunk is frozen (only build fixes are allowed yet). So, \
> > please commit in the essen-branch (if noone else has objections?).
>
> Juan Aquino wrote:
> Thanks Sebastian, I have no svn account, please commit for me.
See http://techbase.kde.org/Contribute/Get_a_SVN_Account to get a KDE SVN-account. \
Can't harm to have a SVN account as long as parts of KDE are still in svn (we are \
moving to git soon).
I committed meanwhile the patch to branches/work/koffice-essen/kspread ( r1203398 ). \
Looks as the patch will be in 2.3.1 but not the just to be released 2.3.0 then cause \
2.3.0 is already in rc-state (sorry :-/ )
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5976/#review9116
-----------------------------------------------------------
On 2010-11-26 02:32:07, Juan Aquino wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5976/
> -----------------------------------------------------------
>
> (Updated 2010-11-26 02:32:07)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Patch for bug 240235, IF function shows wrong result, missing some comparisons \
> between empty and others values.
> - Added comparison:
> empty vs integer
> empty vs float
> empty vs boolean, like openoffice and excel.
>
>
> This addresses bug 240235.
> https://bugs.kde.org/show_bug.cgi?id=240235
>
>
> Diffs
> -----
>
> /trunk/koffice/kspread/Value.cpp 1200862
> /trunk/koffice/kspread/tests/TestLogicFunctions.cpp 1200862
>
> Diff: http://svn.reviewboard.kde.org/r/5976/diff
>
>
> Testing
> -------
>
> test included and passed.
>
>
> Thanks,
>
> Juan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5976/">http://svn.reviewboard.kde.org/r/5976/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 3rd, 2010, 7:08 p.m., <b>Sebastian \
Sauer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks great. koffice/trunk is frozen (only build fixes are allowed yet). \
So, please commit in the essen-branch (if noone else has objections?).</pre> \
</blockquote>
<p>On December 3rd, 2010, 8:02 p.m., <b>Juan Aquino</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Sebastian, I have \
no svn account, please commit for me.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See \
http://techbase.kde.org/Contribute/Get_a_SVN_Account to get a KDE SVN-account. \
Can't harm to have a SVN account as long as parts of KDE are still in svn (we are \
moving to git soon).
I committed meanwhile the patch to branches/work/koffice-essen/kspread ( r1203398 ). \
Looks as the patch will be in 2.3.1 but not the just to be released 2.3.0 then cause \
2.3.0 is already in rc-state (sorry :-/ )</pre> <br />
<p>- Sebastian</p>
<br />
<p>On November 26th, 2010, 2:32 a.m., Juan Aquino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Juan Aquino.</div>
<p style="color: grey;"><i>Updated 2010-11-26 02:32:07</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for bug 240235, IF function shows wrong result, missing some \
comparisons between empty and others values.
- Added comparison:
empty vs integer
empty vs float
empty vs boolean, like openoffice and excel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">test included and passed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240235">240235</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kspread/Value.cpp <span style="color: grey">(1200862)</span></li>
<li>/trunk/koffice/kspread/tests/TestLogicFunctions.cpp <span style="color: \
grey">(1200862)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5976/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic