This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5976/

On December 3rd, 2010, 7:08 p.m., Sebastian Sauer wrote:

Looks great. koffice/trunk is frozen (only build fixes are allowed yet). So, please commit in the essen-branch (if noone else has objections?).

On December 3rd, 2010, 8:02 p.m., Juan Aquino wrote:

Thanks Sebastian, I have no svn account, please commit for me.
See http://techbase.kde.org/Contribute/Get_a_SVN_Account to get a KDE SVN-account. Can't harm to have a SVN account as long as parts of KDE are still in svn (we are moving to git soon).

I committed meanwhile the patch to branches/work/koffice-essen/kspread ( r1203398 ). Looks as the patch will be in 2.3.1 but not the just to be released 2.3.0 then cause 2.3.0 is already in rc-state (sorry :-/ )

- Sebastian


On November 26th, 2010, 2:32 a.m., Juan Aquino wrote:

Review request for KOffice.
By Juan Aquino.

Updated 2010-11-26 02:32:07

Description

Patch for bug 240235, IF function shows wrong result, missing some comparisons between empty and others values.
- Added comparison:
  empty vs integer
  empty vs float
  empty vs boolean, like openoffice and excel.

Testing

test included and passed.
Bugs: 240235

Diffs

  • /trunk/koffice/kspread/Value.cpp (1200862)
  • /trunk/koffice/kspread/tests/TestLogicFunctions.cpp (1200862)

View Diff